feat(@jsii/spec): add loadAssemblyFromBuffer function (#3634)

Usage is demonstrated here: cdklabs/construct-hub#920

Two implementations were considered to fit the use case in construct hub, `loadAssemblyFromBuffer` and `loadAssemblyFromTarball`. I went with loading from a buffer because it allows us to utilize prior art in construct hub for parsing tarballs, does not need an added dependency on `tar`, and causes minimal impact when refactoring the ingestion lambda to use this function.

Also includes a small refactoring of the test suite. 

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0

Author: kaizencc

eslint-config.yaml

@@ -8,6 +8,7 @@ plugins:
   - '@typescript-eslint'
   - import
   - prettier
+  - unicorn
 
 parser: '@typescript-eslint/parser'
 parserOptions:
@@ -43,6 +44,9 @@ rules:
   'prettier/prettier':
     - error
 
+  'unicorn/prefer-node-protocol':
+    - error
+
   '@typescript-eslint/array-type':
     - error
     - default: array-simple
@@ -152,7 +156,9 @@ rules:
 
   'import/no-extraneous-dependencies':
     - error
-    - devDependencies: ['**/test/**'] # Only allow importing devDependencies from tests
+    - devDependencies: # Only allow importing devDependencies from tests
+        - '**/test/**'
+        - '**/*.test.ts'
       optionalDependencies: false # Disallow importing optional dependencies (those shouldn't be used here)
       peerDependencies: false # Disallow importing peer dependencies (those shouldn't be used here)
 

package.json

@@ -27,6 +27,7 @@
     "eslint-import-resolver-typescript": "^2.7.1",
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-prettier": "^4.0.0",
+    "eslint-plugin-unicorn": "^43.0.0",
     "jest": "^28.1.1",
     "jest-circus": "^28.1.1",
     "jest-config": "^28.1.1",

packages/@jsii/benchmarks/bin/benchmark.ts

@@ -1,5 +1,5 @@
 import * as fs from 'fs-extra';
-import * as path from 'path';
+import * as path from 'node:path';
 import * as yargs from 'yargs';
 
 import { benchmarks } from '../lib';

packages/@jsii/benchmarks/lib/benchmark.ts

@@ -1,5 +1,9 @@
-import { Profiler, Session } from 'inspector';
-import { performance, PerformanceObserver, PerformanceEntry } from 'perf_hooks';
+import { Profiler, Session } from 'node:inspector';
+import {
+  performance,
+  PerformanceObserver,
+  PerformanceEntry,
+} from 'node:perf_hooks';
 
 /**
  * Result of a single run of the subject

packages/@jsii/benchmarks/lib/constants.ts

@@ -1,4 +1,4 @@
-import * as path from 'path';
+import * as path from 'node:path';
 
 export const fixturesDir = path.resolve(__dirname, '..', 'fixtures');
 

packages/@jsii/benchmarks/scripts/snapshot-package.ts

@@ -1,8 +1,8 @@
-import * as cp from 'child_process';
 import * as fs from 'fs-extra';
 import * as glob from 'glob';
-import * as os from 'os';
-import * as path from 'path';
+import * as cp from 'node:child_process';
+import * as os from 'node:os';
+import * as path from 'node:path';
 import * as tar from 'tar';
 import * as ts from 'typescript';
 

packages/@jsii/check-node/src/constants.ts

@@ -1,4 +1,4 @@
-import * as process from 'process';
+import * as process from 'node:process';
 import { Range, SemVer } from 'semver';
 
 const ONE_DAY_IN_MILLISECONDS = 86_400_000;

packages/@jsii/check-node/src/index.ts

@@ -1,6 +1,6 @@
 import { Chalk, bgYellow, bgYellowBright, bgRed } from 'chalk';
-import { error } from 'console';
-import { version } from 'process';
+import { error } from 'node:console';
+import { version } from 'node:process';
 
 import { NodeRelease } from './constants';
 

packages/@jsii/integ-test/test/build-cdk.test.ts

@@ -1,8 +1,8 @@
 import { Octokit } from '@octokit/rest';
 import * as dotenv from 'dotenv';
 import { mkdtemp, readdir, remove } from 'fs-extra';
-import { tmpdir } from 'os';
-import * as path from 'path';
+import { tmpdir } from 'node:os';
+import * as path from 'node:path';
 
 import {
   downloadReleaseAsset,

packages/@jsii/integ-test/utils/index.ts

@@ -1,7 +1,7 @@
-import * as cp from 'child_process';
-import { IncomingMessage } from 'http';
-import * as https from 'https';
-import { Readable } from 'stream';
+import * as cp from 'node:child_process';
+import { IncomingMessage } from 'node:http';
+import * as https from 'node:https';
+import { Readable } from 'node:stream';
 import { extract } from 'tar';
 
 /**