TO-51: assign reviewers to environments

backend/migrations/versions/2026_02_24_1744-3514f071a2e5_change_assignee_to_reviewers.py

@@ -0,0 +1,99 @@
+# Copyright (C) 2023 Canonical Ltd.
+#
+# This file is part of Test Observer Backend.
+#
+# Test Observer Backend is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License version 3, as
+# published by the Free Software Foundation.
+#
+# Test Observer Backend is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <https://www.gnu.org/licenses/>.
+
+"""Change assignee to reviewers
+
+Revision ID: 3514f071a2e5
+Revises: f5f3abf809b3
+Create Date: 2026-02-24 17:44:00.000000+00:00
+
+"""
+
+from alembic import op
+import sqlalchemy as sa
+
+# revision identifiers, used by Alembic.
+revision = "3514f071a2e5"
+down_revision = "f5f3abf809b3"
+branch_labels = None
+depends_on = None
+
+
+def upgrade() -> None:
+    # Create the association table for many-to-many relationship
+    op.create_table(
+        "artefact_reviewers_association",
+        sa.Column("artefact_id", sa.Integer(), nullable=False),
+        sa.Column("user_id", sa.Integer(), nullable=False),
+        sa.ForeignKeyConstraint(
+            ["artefact_id"],
+            ["artefact.id"],
+            name="artefact_reviewers_association_artefact_id_fkey",
+            ondelete="CASCADE",
+        ),
+        sa.ForeignKeyConstraint(
+            ["user_id"],
+            ["app_user.id"],
+            name="artefact_reviewers_association_user_id_fkey",
+            ondelete="CASCADE",
+        ),
+        sa.PrimaryKeyConstraint(
+            "artefact_id", "user_id", name="artefact_reviewers_association_pkey"
+        ),
+    )
+
+    # Migrate existing assignee data to the new association table
+    op.execute("""
+        INSERT INTO artefact_reviewers_association (artefact_id, user_id)
+        SELECT id, assignee_id
+        FROM artefact
+        WHERE assignee_id IS NOT NULL
+    """)
+
+    # Drop the old foreign key constraint and column
+    op.drop_constraint("artefact_assignee_id_fkey", "artefact", type_="foreignkey")
+    op.drop_index("artefact_assignee_id_ix", table_name="artefact")
+    op.drop_column("artefact", "assignee_id")
+
+
+def downgrade() -> None:
+    # Re-add the assignee_id column
+    op.add_column(
+        "artefact",
+        sa.Column("assignee_id", sa.Integer(), nullable=True),
+    )
+    op.create_index("artefact_assignee_id_ix", "artefact", ["assignee_id"])
+    op.create_foreign_key(
+        "artefact_assignee_id_fkey",
+        "artefact",
+        "app_user",
+        ["assignee_id"],
+        ["id"],
+    )
+
+    # Migrate data back (take the first reviewer as the assignee)
+    op.execute("""
+        UPDATE artefact
+        SET assignee_id = (
+            SELECT user_id
+            FROM artefact_reviewers_association
+            WHERE artefact_reviewers_association.artefact_id = artefact.id
+            LIMIT 1
+        )
+    """)
+
+    # Drop the association table
+    op.drop_table("artefact_reviewers_association")

backend/migrations/versions/2026_02_27_1621-2f7a130290ea_add_reviewers_to_.py

@@ -0,0 +1,34 @@
+"""Add reviewers to ArtefactBuildEnvironmentReview
+
+Revision ID: 2f7a130290ea
+Revises: 3514f071a2e5
+Create Date: 2026-02-27 16:21:41.550648+00:00
+
+"""
+from alembic import op
+import sqlalchemy as sa
+
+
+# revision identifiers, used by Alembic.
+revision = '2f7a130290ea'
+down_revision = '3514f071a2e5'
+branch_labels = None
+depends_on = None
+
+
+def upgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.create_table('environment_review_reviewers_association',
+    sa.Column('environment_review_id', sa.Integer(), nullable=False),
+    sa.Column('user_id', sa.Integer(), nullable=False),
+    sa.ForeignKeyConstraint(['environment_review_id'], ['artefact_build_environment_review.id'], name=op.f('environment_review_reviewers_association_environment_review_id_fkey'), ondelete='CASCADE'),
+    sa.ForeignKeyConstraint(['user_id'], ['app_user.id'], name=op.f('environment_review_reviewers_association_user_id_fkey'), ondelete='CASCADE'),
+    sa.PrimaryKeyConstraint('environment_review_id', 'user_id', name=op.f('environment_review_reviewers_association_pkey'))
+    )
+    # ### end Alembic commands ###
+
+
+def downgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.drop_table('environment_review_reviewers_association')
+    # ### end Alembic commands ###

backend/schemata/openapi.json

@@ -4105,27 +4105,33 @@
             ],
             "title": "Comment"
           },
-          "assignee_id": {
+          "reviewer_ids": {
             "anyOf": [
               {
-                "type": "integer"
+                "items": {
+                  "type": "integer"
+                },
+                "type": "array"
               },
               {
                 "type": "null"
               }
             ],
-            "title": "Assignee Id"
+            "title": "Reviewer Ids"
           },
-          "assignee_email": {
+          "reviewer_emails": {
             "anyOf": [
               {
-                "type": "string"
+                "items": {
+                  "type": "string"
+                },
+                "type": "array"
               },
               {
                 "type": "null"
               }
             ],
-            "title": "Assignee Email"
+            "title": "Reviewer Emails"
           }
         },
         "type": "object",
@@ -4208,15 +4214,12 @@
             "type": "boolean",
             "title": "Archived"
           },
-          "assignee": {
-            "anyOf": [
-              {
-                "$ref": "#/components/schemas/AssigneeResponse"
-              },
-              {
-                "type": "null"
-              }
-            ]
+          "reviewers": {
+            "items": {
+              "$ref": "#/components/schemas/ReviewerResponse"
+            },
+            "type": "array",
+            "title": "Reviewers"
           },
           "due_date": {
             "anyOf": [
@@ -4269,7 +4272,7 @@
           "status",
           "comment",
           "archived",
-          "assignee",
+          "reviewers",
           "due_date",
           "created_at",
           "bug_link",
@@ -4321,46 +4324,6 @@
         ],
         "title": "ArtefactVersionResponse"
       },
-      "AssigneeResponse": {
-        "properties": {
-          "id": {
-            "type": "integer",
-            "title": "Id"
-          },
-          "launchpad_handle": {
-            "anyOf": [
-              {
-                "type": "string"
-              },
-              {
-                "type": "null"
-              }
-            ],
-            "title": "Launchpad Handle"
-          },
-          "email": {
-            "type": "string",
-            "title": "Email"
-          },
-          "launchpad_email": {
-            "type": "string",
-            "title": "Launchpad Email",
-            "deprecated": true
-          },
-          "name": {
-            "type": "string",
-            "title": "Name"
-          }
-        },
-        "type": "object",
-        "required": [
-          "id",
-          "email",
-          "launchpad_email",
-          "name"
-        ],
-        "title": "AssigneeResponse"
-      },
       "C3TestResult": {
         "properties": {
           "name": {
@@ -5284,6 +5247,46 @@
         "type": "object",
         "title": "RerunRequest"
       },
+      "ReviewerResponse": {
+        "properties": {
+          "id": {
+            "type": "integer",
+            "title": "Id"
+          },
+          "launchpad_handle": {
+            "anyOf": [
+              {
+                "type": "string"
+              },
+              {
+                "type": "null"
+              }
+            ],
+            "title": "Launchpad Handle"
+          },
+          "email": {
+            "type": "string",
+            "title": "Email"
+          },
+          "launchpad_email": {
+            "type": "string",
+            "title": "Launchpad Email",
+            "deprecated": true
+          },
+          "name": {
+            "type": "string",
+            "title": "Name"
+          }
+        },
+        "type": "object",
+        "required": [
+          "id",
+          "email",
+          "launchpad_email",
+          "name"
+        ],
+        "title": "ReviewerResponse"
+      },
       "SnapStage": {
         "type": "string",
         "enum": [

backend/test_observer/controllers/artefacts/artefacts.py

@@ -181,43 +181,51 @@ def patch_artefact(
     if request.comment is not None:
         artefact.comment = request.comment
 
-    assignee_id_set = (
-        hasattr(request, "assignee_id") and "assignee_id" in request.model_fields_set
+    reviewer_ids_set = (
+        hasattr(request, "reviewer_ids") and "reviewer_ids" in request.model_fields_set
     )
-    assignee_email_set = (
-        hasattr(request, "assignee_email")
-        and "assignee_email" in request.model_fields_set
+    reviewer_emails_set = (
+        hasattr(request, "reviewer_emails")
+        and "reviewer_emails" in request.model_fields_set
     )
 
-    if assignee_id_set and assignee_email_set:
+    if reviewer_ids_set and reviewer_emails_set:
         raise HTTPException(
             status_code=422,
-            detail="Cannot specify both assignee_id and assignee_email",
+            detail="Cannot specify both reviewer_ids and reviewer_emails",
         )
 
-    if assignee_id_set:
-        if request.assignee_id is None:
-            artefact.assignee = None
+    # Handle reviewer_ids
+    if reviewer_ids_set:
+        if request.reviewer_ids is None:
+            artefact.reviewers = []
         else:
-            user = db.get(User, request.assignee_id)
-            if user is None:
-                raise HTTPException(
-                    status_code=422,
-                    detail=f"User with id {request.assignee_id} not found",
-                )
-            artefact.assignee = user
-
-    if assignee_email_set:
-        if request.assignee_email is None:
-            artefact.assignee = None
+            reviewers = []
+            for user_id in request.reviewer_ids:
+                user = db.get(User, user_id)
+                if user is None:
+                    raise HTTPException(
+                        status_code=422,
+                        detail=f"User with id {user_id} not found",
+                    )
+                reviewers.append(user)
+            artefact.reviewers = reviewers
+
+    # Handle reviewer_emails
+    if reviewer_emails_set:
+        if request.reviewer_emails is None:
+            artefact.reviewers = []
         else:
-            user = db.scalar(select(User).where(User.email == request.assignee_email))
-            if user is None:
-                raise HTTPException(
-                    status_code=422,
-                    detail=f"User with email '{request.assignee_email}' not found",
-                )
-            artefact.assignee = user
+            reviewers = []
+            for email in request.reviewer_emails:
+                user = db.scalar(select(User).where(User.email == email))
+                if user is None:
+                    raise HTTPException(
+                        status_code=422,
+                        detail=f"User with email '{email}' not found",
+                    )
+                reviewers.append(user)
+            artefact.reviewers = reviewers
 
     db.commit()
     return artefact