TO-51: assign reviewers to environments#601
Open
almeidaraul wants to merge 3 commits intoTO-51/frontend-supports-reviewers-in-environmentsfrom
Open
TO-51: assign reviewers to environments#601almeidaraul wants to merge 3 commits intoTO-51/frontend-supports-reviewers-in-environmentsfrom
almeidaraul wants to merge 3 commits intoTO-51/frontend-supports-reviewers-in-environmentsfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the test-execution “needs_assignment” flow so that, when an artefact is assigned multiple reviewers, each environment review for that artefact also gets assigned a reviewer.
Changes:
- Update reviewer-assignment logic to propagate reviewer assignment onto
ArtefactBuildEnvironmentReview.reviewerswhen multiple artefact reviewers are assigned. - Add controller tests covering (a) no env-review reviewer assignment for “small” artefacts and (b) env-review reviewer assignment across many environments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| backend/test_observer/controllers/test_executions/start_test.py | Assign a reviewer to each environment review when multiple artefact reviewers are assigned. |
| backend/tests/controllers/test_executions/test_start_test.py | Add tests for env-review reviewer assignment behavior for small vs large artefacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
100
to
+104
| expected_number_of_reviewers = (environment_count + 50 - 1) // 50 | ||
|
|
||
| if users: | ||
| self.artefact.reviewers = random.sample(users, min(expected_number_of_reviewers, len(users))) | ||
| if expected_number_of_reviewers > 1: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assign reviewers to environments when assigning them to artefacts