Skip to content

Fix bash completions for old versions #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Fix bash completions for old versions #2238

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e748c30
[bash] Check array subindices when they can be <0.
luis4a0 Sep 14, 2021
2713134
[bash] Auto-complete only if Bash version > 3.
luis4a0 Sep 14, 2021
4633921
[bash] Only disable some completions on Bash < 4.
luis4a0 Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions completions/bash/multipass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,9 @@ _multipass_complete()
COMPREPLY=()
cur="${COMP_WORDS[COMP_CWORD]}"
prev="${COMP_WORDS[COMP_CWORD-1]}"
prev2="${COMP_WORDS[COMP_CWORD-2]}"
if [[ ${COMP_CWORD} -gt 1 ]]; then
prev2="${COMP_WORDS[COMP_CWORD-2]}"
fi
cmd="${COMP_WORDS[1]}"
prev_opts=false
multipass_cmds="transfer delete exec find help info launch list mount networks \
Expand Down Expand Up @@ -239,18 +241,24 @@ _multipass_complete()
;;
"--network")
_multipass_networks
if [[ "${opts}" != "" ]]; then
opts="${opts} bridged id= mode= mac="
if [ "${OLD_BASH}" = true ]; then
if [[ "${opts}" != "" ]]; then
opts="${opts} bridged"
fi
else
if [[ "${opts}" != "" ]]; then
opts="${opts} bridged id= mode= mac="
fi
# TODO: Do use spaces after the completion of an interface name or "bridged".
compopt -o nospace
fi
# TODO: Do use spaces after the completion of an interface name or "bridged".
compopt -o nospace
esac
else
local last_match
_find_last_match ^-.*
local last_match_pos=$?

if [[ ${last_match} == "--network" ]]; then
if [ "${OLD_BASH}" = false ] && [[ ${last_match} == "--network" ]]; then
# We need to complete the option pairs in two steps. One, when the last input char was an equals sign. Two,
# when the user starts to input something, because prev changes when she starts to type a value.
if [[ "${cur}" == '=' ]] && [[ "${prev2}" == ',' || "${prev2}" == '--network' ]] ; then
Expand Down Expand Up @@ -348,4 +356,13 @@ _multipass_complete()

return 0
}

# Check the Bash version. Bash < 4 does not have `compopt`, which we use for completing `launch --network`. We
# disable some completions on that command based on this test.
if [[ $(echo ${BASH_VERSION} | sed s/\\..*//g) -gt 3 ]]; then
OLD_BASH=false
else
OLD_BASH=true
fi

complete -F _multipass_complete multipass