Fix bash completions for old versions #2238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2238 +/- ##
=======================================
Coverage 83.97% 83.97%
=======================================
Files 203 203
Lines 10120 10120
=======================================
Hits 8498 8498
Misses 1622 1622 Continue to review full report at Codecov.
|
luis4a0
force-pushed
the
fix-bash-subindices
branch
from
280a22f to
2b1ecbe
Compare
luis4a0
force-pushed
the
fix-bash-subindices
branch
from
2b1ecbe to
4633921
Compare
townsend2010
approved these changes
Sep 28, 2021
bors bot
added a commit
that referenced
this pull request
Sep 28, 2021
2238: Fix bash completions for old versions r=townsend2010 a=luis4a0 Fixes #2237. Bash 3 complains when an array is indexed with a negative number. This PR checks for negative subindices where they can appear, so we can use the script with older versions. Co-authored-by: Luis Peñaranda <[email protected]>
|
Build failed: |
|
bors retry |
|
Build succeeded:
|
Saviq
pushed a commit
that referenced
this pull request
Oct 12, 2021
2238: Fix bash completions for old versions r=townsend2010 a=luis4a0 Fixes #2237. Bash 3 complains when an array is indexed with a negative number. This PR checks for negative subindices where they can appear, so we can use the script with older versions. Co-authored-by: Luis Peñaranda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2237.
Bash 3 complains when an array is indexed with a negative number. This PR checks for negative subindices where they can appear, so we can use the script with older versions.