Fix: onChange is not called for tap when on Android #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartoszKlonowski
force-pushed
the
fix/onchange-android-tap
branch
from
e16d25b to
76e7462
Compare
BartoszKlonowski
force-pushed
the
fix/onchange-android-tap
branch
from
76e7462 to
a0bf46a
Compare
|
CC: @Hellhiem |
|
@BartoszKlonowski @Hellhiem |
|
@pdaus1405 I still have some of the fixes waiting to be merged, but the v4.2.2 will be published not later than the end of this week (Friday). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #366
The solution is to:
Having the
fromUserset to fixed value offalsewas causing the event to be recognized as avoidable.fromUseris setThis check is now removed as it was found to be redundant and could introduce conflicts for the sliding vs taping.
Please see below presentation of the working fix:
