Skip to content

Commit a0b3d2d

Browse files
Fix: onChange is not called for tap when on Android (#367)
* Indicate user action depending on sliding status * Always send onValueChange, no matter if fromUser
1 parent a0b2619 commit a0b3d2d

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

src/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManager.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,8 @@ public void onStopTrackingTouch(SeekBar seekbar) {
109109
reactContext.getNativeModule(UIManagerModule.class).getEventDispatcher().dispatchEvent(
110110
new ReactSliderEvent(
111111
seekbar.getId(),
112-
((ReactSlider)seekbar).toRealProgress(seekbar.getProgress()), false));
112+
((ReactSlider)seekbar).toRealProgress(seekbar.getProgress()),
113+
!((ReactSlider)seekbar).isSliding()));
113114
}
114115
};
115116

src/js/Slider.js

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -252,14 +252,7 @@ const SliderComponent = (
252252

253253
const onValueChangeEvent = onValueChange
254254
? (event: Event) => {
255-
let userEvent = true;
256-
if (Platform.OS === 'android') {
257-
// On Android there's a special flag telling us the user is
258-
// dragging the slider.
259-
userEvent =
260-
event.nativeEvent.fromUser != null && event.nativeEvent.fromUser;
261-
}
262-
userEvent && onValueChange(event.nativeEvent.value);
255+
onValueChange(event.nativeEvent.value);
263256
}
264257
: null;
265258

0 commit comments

Comments
 (0)