Update imgutil to improve containerd storage driver performance#2427
Merged
jjbustamante merged 2 commits intobuildpacks:mainfrom Aug 18, 2025
Merged
Conversation
- Always try the fast path first (omitting base layers) regardless of storage type. This greatly speeds up creating ephemeral builders in pack when it saves to the daemon. - Added log lines around ephemeral builder creation to help show time spent. Signed-off-by: Jesse Brown <jabrown85@gmail.com>
github-actions
Bot
added
type/enhancement
jkutner
approved these changes
Aug 14, 2025
|
|
||
| return b.image.Save(additionalTags...) | ||
| logger.Debugf("Builder creation completed, starting image save") | ||
| err = b.image.Save(additionalTags...) |
Member
There was a problem hiding this comment.
Do we want to also track with debug logging when:
- Saving a buildpack package
- Saving the app image?
Member
There was a problem hiding this comment.
Or maybe we don't want these logger.Debugf and the PR is just an imageutil update, right?
Contributor
Author
There was a problem hiding this comment.
This was a very targeted improvement in logging so that if users see perf issues I can spot check that it is the save causing issues. Right now there is no log around here at all and you can't even tell what you are stuck waiting on.
Contributor
Author
There was a problem hiding this comment.
Happy to pull it out and put up a different PR but figured I could combo it for efficiencies sake
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Contributor
Author
|
@jjbustamante does these need anything else? |
This was referenced Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Output
Before
After
Documentation
Related
#2272