Skip to content

Commit 58cb893

Browse files
authored
Update imgutil to improve containerd storage driver performance (#2427)
* Update imgutil to improve containerd storage driver performance - Always try the fast path first (omitting base layers) regardless of storage type. This greatly speeds up creating ephemeral builders in pack when it saves to the daemon. - Added log lines around ephemeral builder creation to help show time spent. Signed-off-by: Jesse Brown <jabrown85@gmail.com> * fixup! Update imgutil to improve containerd storage driver performance Signed-off-by: Jesse Brown <jabrown85@gmail.com> --------- Signed-off-by: Jesse Brown <jabrown85@gmail.com>
1 parent f9ac9ca commit 58cb893

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ require (
66
github.com/Masterminds/semver v1.5.0
77
github.com/Microsoft/go-winio v0.6.2
88
github.com/apex/log v1.9.0
9-
github.com/buildpacks/imgutil v0.0.0-20250626173435-7c19c278f3d2
9+
github.com/buildpacks/imgutil v0.0.0-20250814164739-4b1c8875ba7e
1010
github.com/buildpacks/lifecycle v0.20.11
1111
github.com/containerd/errdefs v1.0.0
1212
github.com/docker/cli v28.3.3+incompatible

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973/go.mod h1:Dwedo/Wpr24
9494
github.com/beorn7/perks v1.0.0/go.mod h1:KWe93zE9D1o94FZ5RNwFwVgaQK1VOXiVxmqh+CedLV8=
9595
github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
9696
github.com/beorn7/perks v1.0.1/go.mod h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw=
97-
github.com/buildpacks/imgutil v0.0.0-20250626173435-7c19c278f3d2 h1:31i47pC9YE898vRkFDlubgX9UwxSy8cX/YSXtfPcRLA=
98-
github.com/buildpacks/imgutil v0.0.0-20250626173435-7c19c278f3d2/go.mod h1:UH4th60x/wM1DdH7+eSgzbp0kgsJMhVgngWzXoF21cs=
97+
github.com/buildpacks/imgutil v0.0.0-20250814164739-4b1c8875ba7e h1:a+vpYYeK7E7+3uGqseiRutzKA7yNNjAOPON9+VOADiw=
98+
github.com/buildpacks/imgutil v0.0.0-20250814164739-4b1c8875ba7e/go.mod h1:UH4th60x/wM1DdH7+eSgzbp0kgsJMhVgngWzXoF21cs=
9999
github.com/buildpacks/lifecycle v0.20.11 h1:lr8smVyW59HvkdJj7H3rYbfiNT7ndkV4cV2lQiOnCuo=
100100
github.com/buildpacks/lifecycle v0.20.11/go.mod h1:+YlGlTCwJcyJSp5QvZKxH8k2JOpYzjTE9NYB6CA5CuE=
101101
github.com/cenkalti/backoff/v4 v4.3.0 h1:MyRJ/UdXutAwSAT+s3wNd7MfTIcy71VQueUuFK343L8=

internal/builder/builder.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -652,7 +652,10 @@ func (b *Builder) Save(logger logging.Logger, creatorMetadata CreatorMetadata, a
652652
return errors.Wrap(err, "failed to set working dir")
653653
}
654654

655-
return b.image.Save(additionalTags...)
655+
logger.Debugf("Builder creation completed, starting image save")
656+
err = b.image.Save(additionalTags...)
657+
logger.Debugf("Image save completed")
658+
return err
656659
}
657660

658661
// Helpers

0 commit comments

Comments
 (0)