Imgutil default platform change#1957
Merged
jkutner merged 3 commits intobuildpacks:mainfrom Nov 2, 2023
Merged
Conversation
github-actions
Bot
added
type/enhancement
jjbustamante
requested changes
Nov 1, 2023
jjbustamante
added
type/bug
github-actions
Bot
added
type/enhancement
Signed-off-by: Jerico Pena <jericop@gmail.com>
Signed-off-by: Jerico Pena <jericop@gmail.com>
jericop
force-pushed
the
imgutil-default-platform-change-test
branch
from
8a98128 to
6fae7c7
Compare
jericop
changed the title
Member
|
@jericop I noticed the CI is failing because of this ➜ buildpacks-pack git:(imgutil-default-platform-change-test) make verify
=====> Installing goimports...
cd tools && go install golang.org/x/tools/cmd/goimports
=====> Verifying format...
=====> Installing golangci-lint...
cd tools && go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.1
=====> Linting code...
WARN [linters_context] rowserrcheck is disabled because of generics. You can track the evolution of the generics support by following the https://github.com/golangci/golangci-lint/issues/2649.
internal/layer/writer_factory_test.go:4:2: "archive/tar" imported and not used (typecheck)
"archive/tar"
^
make: *** [lint] Error 1I am not totally sure if it is because bumping the imgutil version ... |
Member
|
Yes, it appears once we updated imgutil version! |
Member
|
@jericop imgutil PR was merged!! could you update your go.mod file to point to that commit? Locally I did it and check the > pack git:(main) go get github.com/buildpacks/imgutil@84d632186b59725f22f7eaace97a0090418091c5
> pack git:(main) make verify
=====> Installing goimports...
cd tools && go install golang.org/x/tools/cmd/goimports
=====> Verifying format...
=====> Installing golangci-lint...
cd tools && go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.1
=====> Linting code...
WARN [linters_context] rowserrcheck is disabled because of generics. You can track the evolution of the generics support by following the https://github.com/golangci/golangci-lint/issues/2649. |
Signed-off-by: Jerico Pena <jericop@gmail.com>
jkutner
approved these changes
Nov 2, 2023
jkutner
reviewed
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change uses a modified version of imgutil that updates the defaultPlatform to support multi-arch builds. See buildpacks/imgutil#232
Output
Before
After
Documentation
Related
Resolves #1958