Use daemon or runtime provided arch instead of amd64#232
Use daemon or runtime provided arch instead of amd64#232natalieparellano merged 1 commit intobuildpacks:mainfrom
Conversation
Signed-off-by: Jerico Pena <jericop@gmail.com>
SummaryThis PR is fixing an issue when running pack using emulation with Additionally, I think the root problem is that we can't define the platform when creating Builders, something we are trying to solve with the multi-arch RFC but improving the default values to be more realistic than hard coding something, I think is a great improvement Local change
Remote change
|
jjbustamante
left a comment
There was a problem hiding this comment.
I tested Jerico script and check pack running and everything looks good to me!
@natalieparellano if you can take a look will be awesome!
The current
defaultPlatformfunctions sets the architecture to "amd64", which causes pack to use theamd64build image, and to install theamd64lifecycle, when creating a new builder from anarm64host with no docker daemon installed.This changes the default platform functions to use the docker daemon os and architecture for local images, and
runtime.GOARCHas the architecture for new remote images.The following log file is the output of a script that was used to identify the issue.
https://github.com/jericop/github-actions/blob/main/buildpacks/create-multi-arch-builders/standalone/imgutil-pr-232-verify-amd64-issue.sh.log
You can see that the script doesn't finish. You can also see that it downloads an
amd64lifecycle rather than thearm64as expected.https://github.com/jericop/github-actions/blob/main/buildpacks/create-multi-arch-builders/standalone/imgutil-pr-232-verify-amd64-issue.sh.log#L159
The following log file is the output of a script was used to identify that an updated version of pack that uses this fix.
https://github.com/jericop/github-actions/blob/main/buildpacks/create-multi-arch-builders/standalone/imgutil-pr-232-verify-fix.sh.log