Add 'volume' cache format support for --cache flag #1490
Merged
jromero merged 2 commits intobuildpacks:mainfrom Jul 27, 2022
Merged
Add 'volume' cache format support for --cache flag #1490jromero merged 2 commits intobuildpacks:mainfrom
jromero merged 2 commits intobuildpacks:mainfrom
Conversation
github-actions
Bot
added
the
type/enhancement
- Extend support for `--cache` flag to volume cache format for both build and launch cache types Signed-off-by: Nitish Gupta <imnitish.ng@gmail.com>
imnitishng
force-pushed
the
cache-flag/build-volume-cache
branch
2 times, most recently
from
1a298d6 to
e106b28
Compare
imnitishng
changed the title
imnitishng
force-pushed
the
cache-flag/build-volume-cache
branch
from
e106b28 to
6207008
Compare
Signed-off-by: Nitish Gupta <imnitish.ng@gmail.com>
imnitishng
force-pushed
the
cache-flag/build-volume-cache
branch
from
6207008 to
1eb52c0
Compare
github-actions
Bot
added
the
type/chore
Codecov Report
@@ Coverage Diff @@
## main #1490 +/- ##
==========================================
- Coverage 81.37% 80.35% -1.02%
==========================================
Files 152 152
Lines 9864 9864
==========================================
- Hits 8026 7925 -101
- Misses 1361 1462 +101
Partials 477 477
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
✅ Approved✅ Existing functionality / defaults
✅ Specifying build volume via flag
✅ Specifying build volume via flag (defaults)
✅ Custom volume name (build)
✅ Custom volume names (build and launch)
|
jromero
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--cacheflag usingformat=volumepack build --cache='type=build;format=volume;name=<random_name>;type=launch;format=volume;name=<random_name>;'as per the RFCOutput
Before
After
Documentation
Related
Resolves #1472
Resolves #1471