tests: Add tests for --cache flag using volume cache format

Signed-off-by: Nitish Gupta <imnitish.ng@gmail.com>

Author: imnitishng

internal/build/lifecycle_execution_test.go

@@ -365,9 +365,10 @@ func testLifecycleExecution(t *testing.T, when spec.G, it spec.S) {
 						TrustBuilder: false,
 						UseCreator:   false,
 						Cache: cache.CacheOpts{
-							CacheType: cache.Build,
-							Format:    cache.CacheImage,
-							Source:    "%%%",
+							Build: cache.CacheInfo{
+								Format: cache.CacheImage,
+								Source: "%%%",
+							},
 						},
 						Termui: fakeTermui,
 					}

internal/cache/cache_opts_test.go

@@ -24,18 +24,18 @@ func TestMetadata(t *testing.T) {
 }
 
 func testCacheOpts(t *testing.T, when spec.G, it spec.S) {
-	when("cache options are passed", func() {
-		it("image cache format with complete options", func() {
+	when("image cache format options are passed", func() {
+		it("with complete options", func() {
 			testcases := []CacheOptTestCase{
 				{
 					name:   "Build cache as Image",
 					input:  "type=build;format=image;name=io.test.io/myorg/my-cache:build",
-					output: "type=build;format=image;name=io.test.io/myorg/my-cache:build",
+					output: "type=build;format=image;name=io.test.io/myorg/my-cache:build;type=launch;format=volume;name=;",
 				},
 				{
 					name:   "Launch cache as Image",
 					input:  "type=launch;format=image;name=io.test.io/myorg/my-cache:build",
-					output: "type=launch;format=image;name=io.test.io/myorg/my-cache:build",
+					output: "type=build;format=volume;name=;type=launch;format=image;name=io.test.io/myorg/my-cache:build;",
 				},
 			}
 
@@ -48,22 +48,17 @@ func testCacheOpts(t *testing.T, when spec.G, it spec.S) {
 			}
 		})
 
-		it("image cache format with missing options", func() {
+		it("with missing options", func() {
 			successTestCases := []CacheOptTestCase{
 				{
 					name:   "Build cache as Image missing: type",
 					input:  "format=image;name=io.test.io/myorg/my-cache:build",
-					output: "type=build;format=image;name=io.test.io/myorg/my-cache:build",
+					output: "type=build;format=image;name=io.test.io/myorg/my-cache:build;type=launch;format=volume;name=;",
 				},
 				{
 					name:   "Build cache as Image missing: format",
 					input:  "type=build;name=io.test.io/myorg/my-cache:build",
-					output: "type=build;format=volume;name=io.test.io/myorg/my-cache:build",
-				},
-				{
-					name:   "Build cache as Image missing: type, format",
-					input:  "name=io.test.io/myorg/my-cache:build",
-					output: "type=build;format=volume;name=io.test.io/myorg/my-cache:build",
+					output: "type=build;format=volume;name=io.test.io/myorg/my-cache:build;type=launch;format=volume;name=;",
 				},
 				{
 					name:       "Build cache as Image missing: name",
@@ -72,10 +67,14 @@ func testCacheOpts(t *testing.T, when spec.G, it spec.S) {
 					shouldFail: true,
 				},
 				{
-					name:       "Build cache as Image missing: format, name",
-					input:      "type=build",
-					output:     "cache 'name' is required",
-					shouldFail: true,
+					name:   "Build cache as Image missing: type, format",
+					input:  "name=io.test.io/myorg/my-cache:build",
+					output: "type=build;format=volume;name=io.test.io/myorg/my-cache:build;type=launch;format=volume;name=;",
+				},
+				{
+					name:   "Build cache as Image missing: format, name",
+					input:  "type=build",
+					output: "type=build;format=volume;name=;type=launch;format=volume;name=;",
 				},
 				{
 					name:       "Build cache as Image missing: type, name",
@@ -94,6 +93,9 @@ func testCacheOpts(t *testing.T, when spec.G, it spec.S) {
 			for _, testcase := range successTestCases {
 				var cacheFlags CacheOpts
 				t.Logf("Testing cache type: %s", testcase.name)
+				if testcase.name == "Everything missing" {
+					print("i am here")
+				}
 				err := cacheFlags.Set(testcase.input)
 
 				if testcase.shouldFail {
@@ -106,7 +108,7 @@ func testCacheOpts(t *testing.T, when spec.G, it spec.S) {
 			}
 		})
 
-		it("image cache format with invalid options", func() {
+		it("with invalid options", func() {
 			testcases := []CacheOptTestCase{
 				{
 					name:       "Invalid cache type",
@@ -142,4 +144,68 @@ func testCacheOpts(t *testing.T, when spec.G, it spec.S) {
 			}
 		})
 	})
+
+	when("volume cache format options are passed", func() {
+		it("with complete options", func() {
+			testcases := []CacheOptTestCase{
+				{
+					name:   "Build cache as Volume",
+					input:  "type=build;format=volume;name=test-build-volume-cache",
+					output: "type=build;format=volume;name=test-build-volume-cache;type=launch;format=volume;name=;",
+				},
+				{
+					name:   "Launch cache as Volume",
+					input:  "type=launch;format=volume;name=test-launch-volume-cache",
+					output: "type=build;format=volume;name=;type=launch;format=volume;name=test-launch-volume-cache;",
+				},
+			}
+
+			for _, testcase := range testcases {
+				var cacheFlags CacheOpts
+				t.Logf("Testing cache type: %s", testcase.name)
+				err := cacheFlags.Set(testcase.input)
+				h.AssertNil(t, err)
+				h.AssertEq(t, testcase.output, cacheFlags.String())
+			}
+		})
+
+		it("with missing options", func() {
+			successTestCases := []CacheOptTestCase{
+				{
+					name:   "Launch cache as Volume missing: format",
+					input:  "type=launch;name=test-launch-volume",
+					output: "type=build;format=volume;name=;type=launch;format=volume;name=test-launch-volume;",
+				},
+				{
+					name:   "Launch cache as Volume missing: name",
+					input:  "type=launch;format=volume",
+					output: "type=build;format=volume;name=;type=launch;format=volume;name=;",
+				},
+				{
+					name:   "Launch cache as Volume missing: format, name",
+					input:  "type=launch",
+					output: "type=build;format=volume;name=;type=launch;format=volume;name=;",
+				},
+				{
+					name:   "Launch cache as Volume missing: type, name",
+					input:  "format=volume",
+					output: "type=build;format=volume;name=;type=launch;format=volume;name=;",
+				},
+			}
+
+			for _, testcase := range successTestCases {
+				var cacheFlags CacheOpts
+				t.Logf("Testing cache type: %s", testcase.name)
+				err := cacheFlags.Set(testcase.input)
+
+				if testcase.shouldFail {
+					h.AssertError(t, err, testcase.output)
+				} else {
+					h.AssertNil(t, err)
+					output := cacheFlags.String()
+					h.AssertEq(t, testcase.output, output)
+				}
+			}
+		})
+	})
 }