Pack loses the names of buildpacks

[haliliceylan]

Signed-off-by: Halil İbrahim ceylan acolops@gmail.com

Summary

When using pack builder create and pack buildpack package, ExtractBuildpacks function was not reading the name variable if the buildpack was down-levels, I fixed this. Additional information is in the issue #1217

Output

Before

After

Documentation

• Should this change be documented?
  • Yes, see #___
  • No

Related

Resolves #1217

[dfreilich]

Thanks for the PR, @haliliceylan ! It looks like there needs to be some changes in the acceptance tests, particularly with the inspect_builder tests. To fix those, you'll probably have to change a lot of the files in https://github.com/buildpacks/pack/tree/main/acceptance/testdata/pack_fixtures, and then put the original ones into the https://github.com/buildpacks/pack/tree/main/acceptance/testdata/pack_previous_fixtures_overrides directory(so that the compatibility tests, which ensures that older visions of pack work, pass). If that's too much, we can do it in a polish PR.

[codecov]

Codecov Report

Merging #1253 (c7b8a2c) into main (3a7e01b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1253      +/-   ##
==========================================
+ Coverage   81.23%   81.23%   +0.01%     
==========================================
  Files         140      140              
  Lines        8581     8582       +1     
==========================================
+ Hits         6970     6971       +1     
  Misses       1176     1176              
  Partials      435      435              

Flag	Coverage Δ
os_linux	79.81% <100.00%> (-0.02%)	⬇️
os_macos	77.17% <100.00%> (-0.03%)	⬇️
os_windows	81.13% <100.00%> (+0.01%)	⬆️
unit	81.23% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[haliliceylan]

I did not get it, some acceptance test are passing, but some of them are not passing like combo-acceptance-test. What i did wrong @dfreilich , @jromero ?

[haliliceylan]

I copied all orginal ones into pack_previous_fixtures_overrides seems not working let me check compability test code.

[haliliceylan]

I think compability tests are not pickup pack_previous_fixtures_overrides directory default. I am open to any suggestion.