Merge pull request #1257 from buildpacks/fix/acceptance_combo_tests

jromero · web-flow · commit 3a7e01bddced · 2021-08-16T16:19:25.000-05:00
Fix using variable reference when running multiple combo tests
diff --git a/acceptance/acceptance_test.go b/acceptance/acceptance_test.go
@@ -91,6 +91,9 @@ func TestAcceptance(t *testing.T) {
 	}
 
 	for _, combo := range inputConfigManager.Combinations() {
+		// see https://github.com/golang/go/wiki/CommonMistakes#using-reference-to-loop-iterator-variable
+		combo := combo
+
 		t.Logf(`setting up run combination %s: %s`,
 			style.Symbol(combo.String()),
 			combo.Describe(assetsConfig),

Original file line number	Diff line number	Diff line change
`@@ -91,6 +91,9 @@ func TestAcceptance(t *testing.T) {`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`for _, combo := range inputConfigManager.Combinations() {`
	`94`	`+ // see https://github.com/golang/go/wiki/CommonMistakes#using-reference-to-loop-iterator-variable`
	`95`	`+ combo := combo`
	`96`	`+`
`94`	`97`	t.Logf(`setting up run combination %s: %s`,
`95`	`98`	`style.Symbol(combo.String()),`
`96`	`99`	`combo.Describe(assetsConfig),`