-
Notifications
You must be signed in to change notification settings - Fork 28
feat: upgrade go version to 1.24.7 #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade go version to 1.24.7 #130
Conversation
WalkthroughGo toolchain bumped from 1.23.1 to 1.24.7 in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
Dockerfile (1)
1-2: Fix stale comment to match the new base image.Comment still references 1.23.1 while
FROMuses 1.24.7.Apply this diff:
-# Use golang:1.23.1-alpine as the base image. +# Use golang:1.24.7-alpine as the base image..github/workflows/release.yml (1)
27-27: Prefer deriving Go version from go.mod in the release workflowReplace the hardcoded version in .github/workflows/release.yml (line 27):
- go-version: 1.24.7 + go-version-file: go.modgo.mod already specifies "go 1.24.7" and other workflows use go-version-file; actions/setup-go will resolve the point release. If you need to pin a patch, use a toolchain directive in go.mod. Verify any Dockerfile references — I couldn't find an official golang:1.24.7-alpine tag.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/release.yml(1 hunks)Dockerfile(1 hunks)go.mod(1 hunks)
🔇 Additional comments (1)
go.mod (1)
3-3: Incorrect —godirective may include patch versions; no change requiredThe
godirective accepts major.minor or major.minor.patch (e.g.,go 1.24.7);toolchainis only needed if you want to explicitly pin a toolchain. go.mod line 3 (go 1.24.7) is valid.Likely an incorrect or invalid review comment.
mertssmnoglu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mrtechit! Could you please use the go-version-file option in the release workflow? If you edit it, I'll approve the pull request and run CI to see the results.
Co-authored-by: Mert Şişmanoğlu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/release.yml (1)
20-21: Consider pinning GitHub Actions by commit SHA for supply‑chain safety.Pin checkout/setup-go/goreleaser actions to SHAs instead of tags to avoid unexpected changes.
Also applies to: 25-26, 34-35
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release.yml(1 hunks)
🔇 Additional comments (1)
.github/workflows/release.yml (1)
27-27: Good switch to go-version-file; aligns with go.mod.This addresses the earlier feedback and keeps the workflow in sync with the toolchain declared in go.mod.
Run this to ensure no other workflows still hardcode a Go version:
#!/bin/bash # List all setup-go usages and highlight hardcoded go-version entries rg -nC2 -g '.github/workflows/*.yml' -P 'uses:\s*actions/setup-go@|go-version-file:|go-version:\s*["'\'']?\d'
|
It's interesting, contract testing job fails but Capture built successfully. I can ignore the contract test since there is no API/Schema changes. |
|
Thank you @mrtechit |
Issue : #126
Upgrade go to 1.24.7