fix(lsp): compare only the formatted range on range formatting #6006
+88
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siketyan
force-pushed
the
fix/lsp-range-formatting
branch
from
cb7b420 to
860a2a0
Compare
siketyan
force-pushed
the
fix/lsp-range-formatting
branch
from
860a2a0 to
7da5311
Compare
Member
|
Remember the changeset :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2260
The LSP implementation of
textDocument/rangeFormattingandtextDocument/onTypeFormattingcompares entire code of the source and the formatted snippet returned byWorkspace::format_range. Return value offormat_rangeonly contains code within the range, so the compared diff deletes most of the code incorrectly.This pull request fixes the behaviour by limiting the source to the formatted range specified in
Printed::range, before comparing it.Test Plan
Added a test to
server.tests.rs.