Skip to content

minor oklab/oklch doc nitpicks #12196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 29, 2024
Merged

minor oklab/oklch doc nitpicks #12196

merged 1 commit into from
Feb 29, 2024

Conversation

Gingeh
Copy link
Contributor

@Gingeh Gingeh commented Feb 29, 2024

Objective

Just some mild annoyances:

  • The Color::Oklaba, Color::Oklcha and oklaba::Oklaba doc comments were inconsistent with the others
  • The crate-level docs didn't include Oklch in the list of representations and misspelt it in a later paragraph

Solution

  • Fix 'em

bushrat011899
bushrat011899 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@bushrat011899 bushrat011899 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

BD103
BD103 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@BD103 BD103 added C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Feb 29, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 29, 2024
Merged via the queue into bevyengine:main with commit b24ab2e Feb 29, 2024
@Gingeh Gingeh deleted the colorspace-nitpick branch February 29, 2024 19:58
@BD103 BD103 added the A-Color Color spaces and color math label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@afonsolage afonsolage afonsolage approved these changes

@bushrat011899 bushrat011899 bushrat011899 approved these changes

@BD103 BD103 BD103 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A-Color Color spaces and color math C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gingeh @afonsolage @bushrat011899 @BD103 @alice-i-cecile