Treat diagonal-tailed ij variants like hooky (not flat-tailed)
#2947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
|
be5invis
requested changes
Nov 15, 2025
| 'bentHookSerifless' { "BentHook" Serifs.None XMiddle.BentHook Marks.Serifless Div.BentHook } | ||
| 'bentHookShortSerifed' { "BentHook" Serifs.Short XMiddle.BentHook Marks.Serifless Div.BentHook } | ||
| 'bentHookSerifed' { "BentHook" Serifs.Long XMiddle.BentHook Marks.Serifed Div.BentHook } | ||
| 'diagonalTailedSerifless' { "DiagonalTailed" Serifs.None XMiddle.BentHook Marks.Serifless Div.BentHook } |
Owner
There was a problem hiding this comment.
Current space is too large. Need to compress it a little.
Contributor
Author
There was a problem hiding this comment.
What about using the width of advanceScaleF and XMiddle of df.middle + [IBalance2 df] for diagonal-tailed j? Preview:
Contributor
Author
There was a problem hiding this comment.
As a comparison, this is the preview of using advanceScaleI and df.middle + [IBalance2 df]:
My fault. advanceScaleI looks better than advanceScaleF.
Owner
There was a problem hiding this comment.
advanceScaleI looks much better.
Remove outdated `dfHook` in `Body.DiagonalTailed` of lower-j
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shifts
jrightward andislightly leftward. The diagonal-tailedjin the Aile version is also wider.Also remove the outdated
dfHookinBody.DiagonalTailedof lower-j. It looks that the correctDivFrameis chosen later inJConfig.But the
dfHookinBody.FlatHookof lower-j remains unchanged, because I don't quite understand the code.