Added logic for replacing colon in log group name and unit test #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markkuhn
reviewed
Aug 9, 2022
src/main/java/software/amazon/cloudwatchlogs/emf/environment/AgentBasedEnvironment.java
Outdated
Show resolved
Hide resolved
markkuhn
approved these changes
Aug 10, 2022
Himtanaya
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#65
Description of changes:
Added logic to replace colon(:) with hyphen(-) when using the service name as part of the log group name. This prevents the violation for log group name regex when the service name is of format “repo:tag” in ECS environment, which is a bug when using the library to publish metrics in ECS without extra configuration.
Measures for testing:
Reproduced the issue in ECS environment with CloudWatch Agent for publishing metrics, then deployed with the new library and the issue is gone.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.