Add package manager endpoints access to install requirements #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
fincd-aws
requested changes
Aug 25, 2025
| ^2^ Access to the {aws} IAM endpoints are only required if you are using {aws} IAM Roles Anywhere for your on-premises IAM credential provider. | ||
| ^2^ Access to the {aws} IAM endpoints are only required if you are using {aws} IAM Roles Anywhere for your on-premises IAM credential provider. | ||
| ^3^ For AL2023 and RHEL, `yum/dnf` is used to install `containerd`, `ca-certificates`, `iptables` and `amazon-ssm-agent`. For Ubuntu, `apt` is used to install `containerd`, `ca-certificates`, and `iptables`, and `snap` is used to install `amazon-ssm-agent`. |
There was a problem hiding this comment.
dnf(oryumrespectively) is used
Forward slashes in text break some automation that we use.
Suggested change
| ^3^ For AL2023 and RHEL, `yum/dnf` is used to install `containerd`, `ca-certificates`, `iptables` and `amazon-ssm-agent`. For Ubuntu, `apt` is used to install `containerd`, `ca-certificates`, and `iptables`, and `snap` is used to install `amazon-ssm-agent`. | |
| ^3^ For AL2023 and RHEL, `dnf` (or `yum` respectively) is used to install `containerd`, `ca-certificates`, `iptables` and `amazon-ssm-agent`. For Ubuntu, `apt` is used to install `containerd`, `ca-certificates`, and `iptables`, and `snap` is used to install `amazon-ssm-agent`. |
There was a problem hiding this comment.
Let's copy this info up into the paragraph at Line 64 too, so the list of packages for each OS isn't only in a footnote.
| @@ -109,13 +109,20 @@ You must have access to the following domains during the installation process wh | |||
| |\https://rolesanywhere.[.replaceable]`region`.amazonaws.com | |||
| |HTTPS | |||
| |443 | |||
|
|
|||
| |Package Manager Endpoints ^3^ | |||
There was a problem hiding this comment.
|Operating System package manager endpoints ^3^
Be specific that we aren't adding other package managers.
Suggested change
| |Package Manager Endpoints ^3^ | |
| |Operating System package manager endpoints ^3^ |
| @@ -109,13 +109,20 @@ You must have access to the following domains during the installation process wh | |||
| |\https://rolesanywhere.[.replaceable]`region`.amazonaws.com | |||
| |HTTPS | |||
| |443 | |||
|
|
|||
| |Package Manager Endpoints ^3^ | |||
| |Package repository endpoints are OS-specific and may vary by geographic region. | |||
There was a problem hiding this comment.
Replace "may" with "might", for style. "May" ends up translated as the month sometimes, "might" has fewer definitions (still several, but its our style).
Suggested change
| |Package repository endpoints are OS-specific and may vary by geographic region. | |
| |Package repository endpoints are OS-specific and might vary by geographic region. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds a note that package manager endpoints need to be allowlisted during hybrid nodes installation and upgrade process.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.