Skip to content

Allow unused required parameters in endpoint rule set #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Madrigal merged 3 commits into from
Sep 9, 2025
Merged

Allow unused required parameters in endpoint rule set #601

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82a2f22
Allow unused required parameters in endpoint rule set
Madrigal Sep 9, 2025
42b29d8
Add comment to explain why add a blank identifier
Madrigal Sep 9, 2025
77668c5
Generate blank variable for string arrays as well
Madrigal Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .../src/main/java/software/amazon/smithy/go/codegen/endpoints/EndpointResolverGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,12 +189,18 @@ private GoWriter.Writable generateResolveMethodBody(EndpointRuleSet ruleset) {
continue;
}
switch (param.getType()) {
case STRING, BOOLEAN ->
case STRING, BOOLEAN -> {
w.write("$L := *$L",
getLocalVarParameterName(param), getMemberParameterName(param));
// even if the parameter is required, it's not guaranteed that it will be used
// so we generate a blank identifier to prevent a compiler error if the
// variable is not used
w.write("_ = $L", getLocalVarParameterName(param));
}
case STRING_ARRAY -> {
w.write("$L := stringSlice($L)",
getLocalVarParameterName(param), getMemberParameterName(param));
w.write("_ = $L", getLocalVarParameterName(param));
}
default -> throw new CodegenException("unrecognized parameter type");
}
Expand Down
Loading