Allow unused required parameters in endpoint rule set #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
approved these changes
Sep 9, 2025
wty-Bryant
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Famously, Go fails to compile if a variable is declared but not used.
While testing, I noticed that when generating code for Smithy's endpoint rule engine, if you declare a variable as
requiredbut don't actually use it, the generated code fails to compile.This is because we always generate an intermediate variable for required parameters, and if unused, we fail to compile.
This change generates an intermediate throwaway to make the compiler happy, but breaking my heart.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.