feat(s2n-quic-dc): implement server tokio builder #2744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boquan-fang
requested review from
Mark-Simulacrum,
WesleyRosenblum and
camshaft
camshaft
reviewed
Aug 6, 2025
* chagne the comment * remove allow async_fn_in_trait since there is no async fun * move import above child module
boquan-fang
force-pushed
the
dcQUIC-tokio-server-builder
branch
from
99181b3 to
8f1ddd8
Compare
camshaft
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
This is the next step of #2741.
Description of changes:
Add dcQUIC tokio server struct and its builder.
Call-outs:
The handshake element of Server needs to have a
local_addr()method that hasn't yet been implemented. Hence, we need aHandshaketrait that temporarily make thelocal_addr()method abstract.Testing:
This is tested in my system.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.