Skip to content

Commit 8f1ddd8

Browse files
committed
address PR comments:
* chagne the comment * remove allow async_fn_in_trait since there is no async fun * move import above child module
1 parent 8577877 commit 8f1ddd8

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

dc/s2n-quic-dc/src/stream/client/tokio.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,14 +276,20 @@ impl Builder {
276276
/// Sets the send buffer for the OS socket handle.
277277
///
278278
/// See `SO_SNDBUF` for more information.
279+
///
280+
/// Note that this only applies to sockets that are created by s2n-quic-dc. Any sockets
281+
/// provided by the application will not inherit this value.
279282
pub fn with_send_buffer(mut self, bytes: usize) -> Self {
280283
self.send_buffer = Some(bytes);
281284
self
282285
}
283286

284287
/// Sets the recv buffer for the OS socket handle.
285288
///
286-
/// See `SO_RCVBUF` for more information..
289+
/// See `SO_RCVBUF` for more information.
290+
///
291+
/// Note that this only applies to sockets that are created by s2n-quic-dc. Any sockets
292+
/// provided by the application will not inherit this value.
287293
pub fn with_recv_buffer(mut self, bytes: usize) -> Self {
288294
self.recv_buffer = Some(bytes);
289295
self

dc/s2n-quic-dc/src/stream/server/tokio.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
22
// SPDX-License-Identifier: Apache-2.0
33

4-
pub mod tcp;
5-
pub mod udp;
6-
74
use crate::{
85
event,
96
path::secret,
@@ -25,8 +22,10 @@ use std::{io, net::SocketAddr, time::Duration};
2522
use tokio::io::unix::AsyncFd;
2623
use tracing::{trace, Instrument as _};
2724

25+
pub mod tcp;
26+
pub mod udp;
27+
2828
// This trait is a temporary solution to abstract local_addr() method until we implement the handshake provider
29-
#[allow(async_fn_in_trait)]
3029
pub trait Handshake: AsRef<secret::Map> + Clone {
3130
fn local_addr(&self) -> SocketAddr;
3231
}

0 commit comments

Comments
 (0)