[Cherry-pick FIPS 2025] Enable hybrid PQ keyshares on FIPS 4.0 branch#3038
Merged
samuel40791765 merged 2 commits intoaws:fips-2025-09-12from Feb 25, 2026
Merged
Conversation
Fixes tests that assume X25519 will be negotiated and will break when the default TLS supported group is changed to X25519MLKEM768. Related to https://github.com/aws/aws-lc/pull/2531/files (cherry picked from commit 4ae8467)
(cherry picked from commit 43721b5)
samuel40791765
had a problem deploying
to
auto-approve
GitHub Actions
Failure
samuel40791765
had a problem deploying
to
auto-approve
GitHub Actions
Error
samuel40791765
had a problem deploying
to
auto-approve
GitHub Actions
Error
samuel40791765
had a problem deploying
to
auto-approve
GitHub Actions
Error
samuel40791765
had a problem deploying
to
auto-approve
GitHub Actions
Error
samuel40791765
had a problem deploying
to
auto-approve
GitHub Actions
Error
nebeid
approved these changes
Feb 24, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fips-2025-09-12 #3038 +/- ##
===================================================
+ Coverage 78.70% 78.73% +0.03%
===================================================
Files 667 667
Lines 113057 113073 +16
Branches 16055 16073 +18
===================================================
+ Hits 88976 89032 +56
+ Misses 23307 23268 -39
+ Partials 774 773 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves
P388277972Description of changes:
The two following commits from main are needed to enable hybrid PQ keyshares on the FIPS 4.0 branch:
These changes are outside the FIPS module and do not change the FIPS integrity hash.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.