Enable Hybrid PQ KeyShares by default #2531
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
N/A
Description of changes:
Adds
X25519MLKEM768
KeyShare to AWS-LC's default SupportedGroups list.Call-outs:
ssl_version_test.cc
was updated to expectSSL_R_UNKNOWN_KEY_EXCHANGE_TYPE
when callingSSL_get_peer_tmp_key()
on an SSL connection that offered X25519MLKEM768. This is because there is no EVP_PKEY type for hybrid keys, only individual X25519 or MLKEM768 keys.Testing:
Unit Tests confirm that X25519MLKEM768 and X25519 are now offered by default by AWS-LC.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.