Skip to content

Enable Hybrid PQ KeyShares by default #2531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alexw91
Copy link
Contributor

@alexw91 alexw91 commented Jul 8, 2025

Issues:

N/A

Description of changes:

Adds X25519MLKEM768 KeyShare to AWS-LC's default SupportedGroups list.

Call-outs:

  • SSL Padding tests to pad TLS ClientHellos up to 512 bytes were updated to disable X25519MLKEM768 in order to keep testing padding functionality.
  • ssl_version_test.cc was updated to expect SSL_R_UNKNOWN_KEY_EXCHANGE_TYPE when calling SSL_get_peer_tmp_key() on an SSL connection that offered X25519MLKEM768. This is because there is no EVP_PKEY type for hybrid keys, only individual X25519 or MLKEM768 keys.

Testing:

Unit Tests confirm that X25519MLKEM768 and X25519 are now offered by default by AWS-LC.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@alexw91 alexw91 changed the title Enable X25519MLKEM769 by default Enable X25519MLKEM768 by default Jul 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.90%. Comparing base (4131f11) to head (c260e9a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2531      +/-   ##
==========================================
+ Coverage   78.88%   78.90%   +0.02%     
==========================================
  Files         640      640              
  Lines      109766   109779      +13     
  Branches    15526    15528       +2     
==========================================
+ Hits        86590    86624      +34     
+ Misses      22479    22457      -22     
- Partials      697      698       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexw91 alexw91 marked this pull request as ready for review July 9, 2025 17:08
@alexw91 alexw91 requested a review from a team as a code owner July 9, 2025 17:08
@darylmartin100 darylmartin100 self-requested a review July 10, 2025 17:33
@darylmartin100
Copy link
Contributor

FYI: I want to hold off on merging this in until we can better quantify the impact.

@alexw91 alexw91 changed the title Enable X25519MLKEM768 by default Enable Hybrid PQ KeyShares by default Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants