chore: convert SkipReplicaDeletion custom resource property to boolean for replica table #34056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes NA
Reason for this change
Currently CloudFormation sends the DynamoDB table replica
onEvent
andisComplete
handler requests withskipReplicaDeletion
property as string (e.g., "true") rather than boolean (true). Cloudformation converts non string to string for custom resource properties when calling the handler. However, the handlerswere checking for boolean value which caused the
isComplete
handler to timeout during delete operationwhen
skipReplicaDeletion
was enabled. This property was introduced in this PR #33953Description of changes
Modified both
onEvent
andisComplete
handlers to explicitly convertskipReplicaDeletion
fromstring to boolean using comparison.
Describe any new or updated permissions being added
NA
Description of how you validated changes
Ran Unit test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license