Skip to content

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Mar 27, 2025

Issue # (if applicable)

Closes #33952

Reason for this change

Allow users to retain table replica

Description of changes

By default, we will retain table replica if table is retain. Otherwise, replica will be deleted by default.

Users can optionally use the new field to set replica to destroy even if table is retain.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

New integ tests and unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. p1 labels Mar 27, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 27, 2025 23:36
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 27, 2025
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (0c77cb6) to head (e114ec3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33953   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6955     6955           
  Branches     1173     1173           
=======================================
  Hits         5730     5730           
  Misses       1120     1120           
  Partials      105      105           
Flag Coverage Δ
suite.unit 82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.38% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GavinZZ GavinZZ changed the title fix: table v1 retain replica table if table is retain fix(dynamodb): table v1 retain replica table if table is retain Mar 28, 2025
@GavinZZ GavinZZ marked this pull request as ready for review March 28, 2025 17:58
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 28, 2025
Copy link
Contributor

@xazhao xazhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Have one comment regarding the default behavior change

Copy link
Contributor

mergify bot commented Mar 28, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e114ec3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Mar 28, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 21d0a5c into main Mar 28, 2025
20 checks passed
@mergify mergify bot deleted the yuanhaoz/table-fix branch March 28, 2025 21:51
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2025
@GavinZZ GavinZZ changed the title fix(dynamodb): table v1 retain replica table if table is retain fix(dynamodb): table v1 retain replica table if table is retain (under feature flag) Mar 28, 2025
@GavinZZ
Copy link
Contributor Author

GavinZZ commented Mar 28, 2025

Decided to add a feature flag, #33970

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dynamodb: TableV1 has no way to persist replica table on stack deletion even if retain is set
3 participants