-
Notifications
You must be signed in to change notification settings - Fork 7
Support updating remote when ABAP files are edited #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,6 @@ | |
import org.eclipse.core.resources.ResourcesPlugin; | ||
import org.eclipse.core.runtime.CoreException; | ||
import org.eclipse.core.runtime.IPath; | ||
|
||
import org.eclipse.core.runtime.NullProgressMonitor; | ||
import org.eclipse.core.runtime.Path; | ||
import org.eclipse.jface.action.IAction; | ||
|
@@ -90,6 +89,7 @@ | |
import software.aws.toolkits.eclipse.amazonq.util.QEclipseEditorUtils; | ||
import software.aws.toolkits.eclipse.amazonq.preferences.AmazonQPreferencePage; | ||
import software.aws.toolkits.eclipse.amazonq.telemetry.service.DefaultTelemetryService; | ||
import software.aws.toolkits.eclipse.amazonq.util.AbapUtil; | ||
import software.aws.toolkits.eclipse.amazonq.util.Constants; | ||
import software.aws.toolkits.eclipse.amazonq.util.ObjectMapperFactory; | ||
import software.aws.toolkits.eclipse.amazonq.util.ThemeDetector; | ||
|
@@ -539,11 +539,19 @@ public final void didCopyFile(final Object params) { | |
|
||
@Override | ||
public final void didWriteFile(final Object params) { | ||
var path = extractFilePathFromParams(params); | ||
if (AbapUtil.isAbapFile(path)) { | ||
AbapUtil.updateAdtServer(path); | ||
} | ||
refreshProjects(); | ||
} | ||
|
||
@Override | ||
public final void didAppendFile(final Object params) { | ||
var path = extractFilePathFromParams(params); | ||
if (AbapUtil.isAbapFile(path)) { | ||
AbapUtil.updateAdtServer(path); | ||
} | ||
refreshProjects(); | ||
} | ||
|
||
|
@@ -559,6 +567,7 @@ public final void didCreateDirectory(final Object params) { | |
|
||
private void refreshProjects() { | ||
WorkspaceUtils.refreshAllProjects(); | ||
WorkspaceUtils.refreshAdtViews(); | ||
} | ||
|
||
private boolean isUriInWorkspace(final String uri) { | ||
|
@@ -577,6 +586,15 @@ private boolean isUriInWorkspace(final String uri) { | |
} | ||
} | ||
|
||
private String extractFilePathFromParams(final Object params) { | ||
if (params instanceof Map) { | ||
var map = (Map<?, ?>) params; | ||
Object path = map.get("path"); | ||
return path != null ? path.toString() : null; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we need a instance check before toString? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The path !=null check does that I believe |
||
} | ||
return null; | ||
} | ||
|
||
@Override | ||
public final void sendPinnedContext(final Object params) { | ||
Object updatedParams = params; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder do we still want to depend on the extension or should we use editor to check if is in adt plugin environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this situation (file not open)we only have the path, no editor is available in this case