Support updating remote when ABAP files are edited #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rli
approved these changes
Aug 7, 2025
| if (params instanceof Map) { | ||
| var map = (Map<?, ?>) params; | ||
| Object path = map.get("path"); | ||
| return path != null ? path.toString() : null; |
There was a problem hiding this comment.
do we need a instance check before toString?
There was a problem hiding this comment.
The path !=null check does that I believe
|
|
||
| // Check if file is already open in an editor | ||
| var existingEditor = findOpenEditor(page, workspaceFile); | ||
| if (existingEditor != null && AbapUtil.isAdtEditor(existingEditor.getClass().getName())) { |
There was a problem hiding this comment.
Updated the abapfile check to confirm for abap adt file instead in the callstack before.
XiaoxuanLu
reviewed
Aug 7, 2025
Comment on lines
+543
to
+544
| if (AbapUtil.isAbapFile(path)) { | ||
| AbapUtil.updateAdtServer(path); |
There was a problem hiding this comment.
I wonder do we still want to depend on the extension or should we use editor to check if is in adt plugin environment
There was a problem hiding this comment.
For this situation (file not open)we only have the path, no editor is available in this case
XiaoxuanLu
approved these changes
Aug 7, 2025
shruti0085
added a commit
that referenced
this pull request
Aug 13, 2025
Merges feature branch containing improvements for ADT ABAP support into main. Relevant PRs * adt support #487 * Support updating remote when ABAP files are edited #495 * handle the null case for contentType in adt plugin environment #496 * Fix: Handle removing paint listeners with ADT viewer and allow multiline text in inline chat #500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Ensures when Q edits an existing file associated with an ABAP ADT project, the update is communicated to the remote server. This is done by marking the editor for the file as dirty and triggering a save which in turn informs remote. When a file is not opened, it is opened in an invisible editor to do the same. For new files not associated with the current workspace, when Q creates a new one user will be informed to configure it appropriately as it cannot be configured for them by Q directly due to the limitations around ABAP ADT projects.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.