Skip to content

Conversation

sdangol
Copy link
Contributor

@sdangol sdangol commented Aug 26, 2025

Summary

This PR allows the secrets to be inherited from the parent workflow to the Update SSM workflow to fix the issue during running the release workflow
The inheritance was previously updated because of a security finding.

Changes

Please provide a summary of what's being changed

  • Reverted the explicit specification of secrets to use inherit keyword since the update parameter SSM would use secrets for each regions

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #4387


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Aug 26, 2025
@sdangol sdangol self-assigned this Aug 26, 2025
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Aug 26, 2025
@sdangol sdangol requested a review from sthulb August 26, 2025 12:19
@sdangol
Copy link
Contributor Author

sdangol commented Aug 26, 2025

@sthulb One of the changes we did last time didn't succeed in the release pipeline today. This seems to be because of the secret(role) not being available to the workflow when used as a reusable workflow.
I've reverted the changes to use the inherit keyword. But, this would introduce a SonarQube finding about using inherit for secrets.
What do you suggest we should do?

@dreamorosi
Copy link
Contributor

I've marked them as safe on SonarCloud - let's improve the explanation documenting what we're doing, why, and how we're addressing concerns rather than just saying "it's going to trigger SonarCloud findings".

Copy link

@dreamorosi dreamorosi merged commit 50da0e6 into main Aug 26, 2025
39 checks passed
@dreamorosi dreamorosi deleted the fix/update-ssm-secrets branch August 26, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Error on the Update SSM job on Make Release workflow
2 participants