Skip to content

Commit 50da0e6

Browse files
authored
improv(ci): set secrets as inherited for update ssm workflow (#4388)
1 parent f1ecc6d commit 50da0e6

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

.github/workflows/make-release.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,8 @@ jobs:
9494
publish_layer:
9595
needs: publish-npm
9696
secrets:
97-
AWS_LAYERS_BETA_ROLE_ARN: ${{ secrets.AWS_LAYERS_BETA_ROLE_ARN }}
98-
AWS_LAYERS_PROD_ROLE_ARN: ${{ secrets.AWS_LAYERS_PROD_ROLE_ARN }}
99-
TOKEN_GITHUB: ${{ secrets.GITHUB_TOKEN }}
97+
# We use "inherit" because need to propagate the secrets to the reusable workflow, secrets are already scoped by using GitHub's deployment environments to mitigate the risk of secret exposure.
98+
inherit
10099
permissions:
101100
id-token: write
102101
contents: write

.github/workflows/publish_layer.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,9 @@ jobs:
9797
environment: prod
9898
package_version: ${{ inputs.latest_published_version }}
9999
layer-version: ${{ needs.deploy-prod.outputs.layer-version }}
100+
secrets:
101+
# We use "inherit" because need to propagate the secrets to the reusable workflow, secrets are already scoped by using GitHub's deployment environments to mitigate the risk of secret exposure.
102+
inherit
100103

101104
update_layer_arn_docs:
102105
needs: [deploy-prod]

0 commit comments

Comments
 (0)