nixos/postgresql: add upgradeFrom option
#117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3.{3,4,5} all reached EOL
It is unused.
It fails to apply
Which were EOL long ago.
Co-authored-by: Robert Scott <[email protected]>
USE_OPTIMIZE_FOR_ARCHITECTURE was removed without commit in a prior commit. This is because it was removed upstream: arangodb/arangodb@cc860c3 This is unfortunate - now /proc/cpuinfo is read unconditionally for feature detection. Some other means of feature detection will have to be found.
It seems that gcc11 - though reportedly supported - introduced some constraint that arangodb fails to compile with.
Avoid non-deterministic builds of ArangoDB proper. Note that this provides 0 guarantees about the vendored libraries doing anything similar.
If -DTARGET_ARCHITECTURE is supplied arango's cmake configuration will not use /proc/cpuinfo for feature detection. However, `generic` and `none` options both fail when building the vendored v8. This workaround provides some defaults, but warns if no override is provided.
As far as I can tell, this can cause compile failures when building the vendored abseil_cpp if choosing a target arch that does not support sse. This might be possible to determine programmatically, but it is more flexible to let the user decide.
For which no reliable default target architecture is provided upstream.
Co-authored-by: Sandro <[email protected]>
jsoo1
force-pushed
the
jsoo1/main/upgradable-postgres
branch
4 times, most recently
from
6b18874 to
1490c15
Compare
With accompanying nixos vm test.
jsoo1
force-pushed
the
jsoo1/main/upgradable-postgres
branch
from
1490c15 to
8bbd2e6
Compare
jsoo1
force-pushed
the
main
branch
2 times, most recently
from
6580daa to
d83f082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With accompanying nixos vm test.