Skip to content

Commit 4dccdf4

Browse files
raboofjsoo1
authored andcommitted
maven: improve buildMavenPackage offline mode
The maven `dependency:go-offline` plugin has various issues (see https://issues.apache.org/jira/browse/MDEP-204 and other issues in that tracker), which the dedicated plugin from https://github.com/qaware/go-offline-maven-plugin largely fixes. I have confirmed that for an application I'm packaging outside of nixpkgs, dependency-track, this indeed makes the build work while it didn't with `dependency:go-offline`. The offline mode is only used in one place in nixpkgs, for lemminx. That build still succeeds and the program starts, though I haven't tested further.
1 parent 91bdd5b commit 4dccdf4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pkgs/development/tools/build-managers/apache-maven/build-package.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ let
3232
buildPhase = ''
3333
runHook preBuild
3434
'' + lib.optionalString buildOffline ''
35-
mvn dependency:go-offline -Dmaven.repo.local=$out/.m2 ${mvnDepsParameters}
35+
mvn de.qaware.maven:go-offline-maven-plugin:1.2.8:resolve-dependencies -Dmaven.repo.local=$out/.m2 ${mvnDepsParameters}
3636
3737
for artifactId in ${builtins.toString manualMvnArtifacts}
3838
do

0 commit comments

Comments
 (0)