-
Notifications
You must be signed in to change notification settings - Fork 272
Move CI tasks to Taskfile.yml #1610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this overall lgtm, left few comments. we should get @maru-ava's approval.
Additionally, the Golang unit tests for Windows need to be removed (see the 1 pending check below) - they obviously won't work anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just removal of run_env
left...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Co-authored-by: Ceyhun Onur <[email protected]>
Why this should be merged
See issue 1023 in the coreth repository. @ceyonur requested that issue be addressed here too.
test-e2e-precompile
by creating individual test tasks and then creating a parent task that runs everything.How this works
Reassigns how scripts are called instead of directly calling them in workflow files.
How this was tested
As this changed how the unit tests themselves are executed, I will let the automatic unit tests run
Need to be documented?
No
Need to update RELEASES.md?
No