Skip to content

Move CI tasks to Taskfile.yml #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 4, 2025
Merged

Move CI tasks to Taskfile.yml #1610

merged 20 commits into from
Jul 4, 2025

Conversation

JonathanOppenheimer
Copy link
Member

@JonathanOppenheimer JonathanOppenheimer commented Jun 26, 2025

Why this should be merged

See issue 1023 in the coreth repository. @ceyonur requested that issue be addressed here too.

  • Enables both discoverability of available tasks (./scripts/run_task.sh without arguments outputs all tasks) and maximizes the potential for reproducing what runs in CI - it can be as simple as task [ci job].
  • Makes testing patterns consistent with the AvalancheGo repository and should reduce the complexity of the workflow.
  • Simplifies the test-e2e-precompile by creating individual test tasks and then creating a parent task that runs everything.

How this works

Reassigns how scripts are called instead of directly calling them in workflow files.

How this was tested

As this changed how the unit tests themselves are executed, I will let the automatic unit tests run

Need to be documented?

No

Need to update RELEASES.md?

No

@JonathanOppenheimer JonathanOppenheimer requested a review from a team as a code owner June 26, 2025 15:11
@JonathanOppenheimer JonathanOppenheimer changed the title Move CI tasks to Takefile.yml Move CI tasks to Taskfile.yml Jun 26, 2025
Copy link
Collaborator

@ceyonur ceyonur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this overall lgtm, left few comments. we should get @maru-ava's approval.

@ceyonur ceyonur requested a review from maru-ava June 27, 2025 15:27
@JonathanOppenheimer
Copy link
Member Author

JonathanOppenheimer commented Jun 27, 2025

Additionally, the Golang unit tests for Windows need to be removed (see the 1 pending check below) - they obviously won't work anymore.

Copy link
Contributor

@maru-ava maru-ava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just removal of run_env left...

Copy link
Contributor

@maru-ava maru-ava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@ceyonur ceyonur enabled auto-merge July 3, 2025 15:56
@ceyonur ceyonur added this pull request to the merge queue Jul 4, 2025
Merged via the queue into master with commit 7d37829 Jul 4, 2025
13 checks passed
@ceyonur ceyonur deleted the move-ci-tasks branch July 4, 2025 10:07
JonathanOppenheimer added a commit that referenced this pull request Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants