Closed
Description
I've noticed a trend in recent subnet-evm and coreth PRs to move functionality from scripts to CI workflows. I think this is counterproductive - it encourages round-tripping through CI instead of just running things locally.
For future, I recommend following the example of avalanchego:
- All actions executed by CI are defined as tasks in the project Taskfile.yml
- The actionlint job enforces the requirement to not use scripts/ from CI
This enables both discoverability of available tasks (./scripts/run_task.sh without arguments outputs all tasks) and maximizes the potential for reproducing what runs in CI - it can be as simple as task [ci job]
.
Originally posted by @maru-ava in #1000 (review)
Metadata
Metadata
Assignees
Labels
No labels