Connectrpc info api #4017
Connectrpc info api #4017
Conversation
| type ConnectInfoService struct { | ||
| *info.Info | ||
| } |
There was a problem hiding this comment.
As discussed offline, it's do this in the info package in service.go. This should make the diff easier to review, and is more aligned with the goal of this project of migrating the existing api rather than removing one and adding a new one. This is kind of implemented in a nice way since we just wrap the old api and convert it into the new response type, but I just don't want the repo in an inconsistent state where we have two sets of apis.
examples/info_connect_client/main.go
Outdated
|
|
||
| // Request node version | ||
| fmt.Println("Fetching node version...") | ||
| versionResp, err := client.GetNodeVersion( |
There was a problem hiding this comment.
We should remove this file from the PR - since it seems to be used for manual testing purposes. If you want to test this PR you can follow some examples from our docs https://build.avax.network/docs/api-reference/info-api#infogetnodeversion that use curl from the command line to issue requests
joshua-kim
force-pushed
the
connectrpc-info-api
branch
from
a0d0c8b to
559e0d8
Compare
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
joshua-kim
force-pushed
the
connectrpc-info-api
branch
from
854da11 to
e8c5de4
Compare
|
Looks like this was moved to #4033 |
Why this should be merged
How this works
How this was tested
Need to be documented in RELEASES.md?