[airflow] Add autofixes for AIR302 and AIR312
#17942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lee-W
changed the title
airflow] Get rid of ProviderName::Name and replace them with ProviderName::AutoImport for enabling auto fixing
Lee-W
changed the title
airflow] Get rid of ProviderName::Name and replace them with ProviderName::AutoImport for enabling auto fixingairflow] Get rid of ProviderName::Name and replace them with ProviderName::AutoImport for enabling auto fixing (AIR302, AIR312)
Lee-W
changed the title
airflow] Get rid of ProviderName::Name and replace them with ProviderName::AutoImport for enabling auto fixing (AIR302, AIR312)airflow] Get rid of ProviderReplacement::Name and replace them with ProviderReplacement::AutoImport for enabling auto fixing (AIR302, AIR312)
This was referenced May 8, 2025
Lee-W
force-pushed
the
refactor-AIR302-ARI312
branch
from
fa7065a to
5ce52af
Compare
Lee-W
force-pushed
the
refactor-AIR302-ARI312
branch
2 times, most recently
from
07f64dd to
842be1b
Compare
|
Just need to fix the very minor clippy lint. |
… and replace them as ProviderName::AutoImport
Lee-W
force-pushed
the
refactor-AIR302-ARI312
branch
from
842be1b to
39df309
Compare
|
Thanks for reminding me! I forgot to backport the fix to this one. |
ntBre
added
rule
ntBre
changed the title
airflow] Get rid of ProviderReplacement::Name and replace them with ProviderReplacement::AutoImport for enabling auto fixing (AIR302, AIR312)airflow] Add autofixes for AIR302 and AIR312
Glyphack
pushed a commit
to Glyphack/ruff
that referenced
this pull request
May 21, 2025
<!-- Thank you for contributing to Ruff! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary <!-- What's the purpose of the change? What does it do, and why? --> `ProviderReplacement::Name` was designed back when we only wanted to do linting. Now we also want to fix the user code. It would be easier for us to replace them with better AutoImport struct. ## Test Plan <!-- How was it tested? --> The test fixture has been updated as some cases can now be fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ProviderReplacement::Namewas designed back when we only wanted to do linting. Now we also want to fix the user code. It would be easier for us to replace them with better AutoImport struct.Test Plan
The test fixture has been updated as some cases can now be fixed