Skip to content

Conversation

Lee-W
Copy link
Contributor

@Lee-W Lee-W commented May 8, 2025

Summary

In the later development of Airflow 3.0, backward compatibility was not added for some cases. Thus, the following rules are moved back to AIR302

  • airflow.hooks.subprocess.SubprocessResult → airflow.providers.standard.hooks.subprocess.SubprocessResult
  • airflow.hooks.subprocess.working_directory → airflow.providers.standard.hooks.subprocess.working_directory
  • airflow.operators.datetime.target_times_as_dates → airflow.providers.standard.operators.datetime.target_times_as_dates
  • airflow.operators.trigger_dagrun.TriggerDagRunLink → airflow.providers.standard.operators.trigger_dagrun.TriggerDagRunLink
  • airflow.sensors.external_task.ExternalTaskSensorLink → airflow.providers.standard.sensors.external_task.ExternalDagLink (This one contains a minor change)
  • airflow.sensors.time_delta.WaitSensor → airflow.providers.standard.sensors.time_delta.WaitSensor

Test Plan

Copy link
Contributor

github-actions bot commented May 8, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@Lee-W Lee-W changed the title refactor(AIR302,-AIR312): get rid of ProviderReplacement::ProviderNam… [airflow] Move rules from AIR302 to AIR312 May 8, 2025
@Lee-W Lee-W changed the title [airflow] Move rules from AIR302 to AIR312 [airflow] Move rules from AIR312 to AIR302 May 8, 2025
@Lee-W Lee-W force-pushed the move-wrongly-categorized-AIR312-rules branch from 29e9d66 to 6afa95a Compare May 8, 2025 11:45
@Lee-W
Copy link
Contributor Author

Lee-W commented May 8, 2025

It depends on #17942

@Lee-W Lee-W force-pushed the move-wrongly-categorized-AIR312-rules branch from 6afa95a to 5912683 Compare May 12, 2025 10:57
@ntBre ntBre self-requested a review May 13, 2025 01:39
@Lee-W Lee-W force-pushed the move-wrongly-categorized-AIR312-rules branch 3 times, most recently from af802f8 to 55a567e Compare May 16, 2025 09:27
@Lee-W Lee-W marked this pull request as ready for review May 16, 2025 10:32
… compatibility was not added for some cases. Thus, the following rules are moved back to AIR302

    airflow.hooks.subprocess.SubprocessResult → airflow.providers.standard.hooks.subprocess.SubprocessResult
    airflow.hooks.subprocess.working_directory → airflow.providers.standard.hooks.subprocess.working_directory
    airflow.operators.datetime.target_times_as_dates → airflow.providers.standard.operators.datetime.target_times_as_dates
    airflow.operators.trigger_dagrun.TriggerDagRunLink → airflow.providers.standard.operators.trigger_dagrun.TriggerDagRunLink
    airflow.sensors.external_task.ExternalTaskSensorLink → airflow.providers.standard.sensors.external_task.ExternalDagLink (This one contains a minor change)
    airflow.sensors.time_delta.WaitSensor → airflow.providers.standard.sensors.time_delta.WaitSensor
@Lee-W Lee-W force-pushed the move-wrongly-categorized-AIR312-rules branch from 55a567e to 15dfa36 Compare May 19, 2025 15:08
@ntBre ntBre added rule Implementing or modifying a lint rule preview Related to preview mode features labels May 19, 2025
Copy link
Contributor

@ntBre ntBre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ntBre ntBre merged commit 99cb89f into astral-sh:main May 19, 2025
34 checks passed
dcreager added a commit that referenced this pull request May 19, 2025
…rals

* origin/main:
  [ty] Add hint that PEP 604 union syntax is only available in 3.10+ (#18192)
  Unify `Message` variants (#18051)
  [`airflow`] Update `AIR301` and `AIR311` with the latest Airflow implementations (#17985)
  [`airflow`] Move rules from `AIR312` to `AIR302` (#17940)
  [ty] Small LSP cleanups (#18201)
  [ty] Show related information in diagnostic (#17359)
  Default `src.root` to `['.', '<project_name>']` if the directory exists (#18141)
dcreager added a commit that referenced this pull request May 19, 2025
* main:
  [ty] Use first matching constructor overload when inferring specializations (#18204)
  [ty] Add hint that PEP 604 union syntax is only available in 3.10+ (#18192)
  Unify `Message` variants (#18051)
  [`airflow`] Update `AIR301` and `AIR311` with the latest Airflow implementations (#17985)
  [`airflow`] Move rules from `AIR312` to `AIR302` (#17940)
  [ty] Small LSP cleanups (#18201)
  [ty] Show related information in diagnostic (#17359)
  Default `src.root` to `['.', '<project_name>']` if the directory exists (#18141)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Related to preview mode features rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants