Skip to content

Conversation

voltur01
Copy link
Contributor

No description provided.

Copy link
Contributor

@kiranchandramohan kiranchandramohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few nits, if I understood correctly the syntax.

[A clear and concise description of what the bug is]

**To Reproduce**
1. [Steps to reproduce]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. [Steps to reproduce]
[Steps to reproduce]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to suggest providing steps as a numbered list, if it makes sense.

**[Risks]**
[Optional: Consider risks and mitigations, if relevant]

**Alternatives**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Alternatives**
**[Alternatives]**

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, should be other way around: "Optional" removed from the description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by removing "Optional"

[A clear and concise description of any alternative solutions or features you've considered]

**Additional context**
Add any other context or screenshots about the feature request here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Add any other context or screenshots about the feature request here.
[Add any other context or screenshots about the feature request here.]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix, thanks!

[A clear and concise description of any alternative solutions or features you've considered]

**Additional context**
Add any other context or screenshots about the feature request here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Missing surrounding [].

[Optional: Highlight why the proposal makes sense, especially if this is not a problem solving, but exploiting an opportunity]

**[Implementation or Transition]**
[Optional: Some solutions many need multiple steps to be implemented or require migration/transition period from the previous approach - outline the plan here]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: many -> may

Suggested change
[Optional: Some solutions many need multiple steps to be implemented or require migration/transition period from the previous approach - outline the plan here]
[Optional: Some solutions may need multiple steps to be implemented or require a migration/transition period from the previous approach - outline the plan here]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix, thanks!

Change-Id: I87705dc1bbcc8c60384539184f5a28b91d282095
Copy link
Contributor

@kiranchandramohan kiranchandramohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@voltur01 voltur01 merged commit 71a9825 into arm-software May 1, 2025
@voltur01 voltur01 deleted the voltur01-issue-templates branch May 1, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants