Skip to content

Conversation

voltur01
Copy link
Contributor

Add Quick Links section (including ways to provide feedback) to the main README.
Add feedback and contribution sections at the end of Linux toolchain README.

Add Quick Links section (including ways to provide feedback) to the main README.
Add feedback and contribution sections at the end of Linux toolchain README.

Change-Id: I0aea207b3365456c13b92e33ecfd4c5d845e7d49
@LukeIreland1
Copy link

LGTM

pratlucas
pratlucas previously approved these changes Apr 30, 2025
Copy link
Contributor

@pratlucas pratlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@kiranchandramohan kiranchandramohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @voltur01. Couple of comments.


## Providing feedback and reporting issues

Please raise an issue via [Github issues](https://github.com/arm/arm-toolchain/issues).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want users to prefix [ATFL] for ATfL issues?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have labels https://github.com/arm/arm-toolchain/labels for ATfE and ATfL.

I would not require it to be set, but I can add a hint both here and in ATfE version of README.

Also, Arm Toolchain variant was added to the "bug" issue template #305 to help clarify.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Fix path to CONTRBUTING.md and refer to ATfE/ATfL labels.

Change-Id: I0c2c6ab1c12b768431a05a0473ca4634c0ed9372
Copy link
Contributor

@kiranchandramohan kiranchandramohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Thanks @voltur01 for the changes.

Copy link
Contributor

@pawosm-arm pawosm-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is OK in the ATfL part. Do we really need to modify the top-level README file? It's LLVM's...
Approving tentatively.

@voltur01
Copy link
Contributor Author

It is OK in the ATfL part. Do we really need to modify the top-level README file? It's LLVM's... Approving tentatively.

The top-level README is our own https://github.com/arm/arm-toolchain/blob/arm-software/README.md - very minimal one, so I thought that it would be useful to add some links, instead of expecting people to click through arm-software -> embedded or linux -> ...

@pawosm-arm
Copy link
Contributor

It is OK in the ATfL part. Do we really need to modify the top-level README file? It's LLVM's... Approving tentatively.

The top-level README is our own https://github.com/arm/arm-toolchain/blob/arm-software/README.md - very minimal one, so I thought that it would be useful to add some links, instead of expecting people to click through arm-software -> embedded or linux -> ...

Ah yes, now I see that the milk has been spilled already and we replaced the contents of this file entirely. Thus I'm OK with the change discussed here.

@voltur01 voltur01 merged commit f99151b into arm:arm-software Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants