docs: adds a section for OCI private repos in OCI dcos

[ppapapetrou76]

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Title of the PR
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[blakepettersson]

That comment applies if you use a "helm classic" repository credential. Private repositories are fully supported with OCI (if you use a credential of type oci)

[ppapapetrou76]

That comment applies if you use a "helm classic" repository credential. Private repositories are fully supported with OCI (if you use a credential of type oci)

Thanks @blakepettersson , how should I phrase it then? 🤔

[blakepettersson]

@ppapapetrou76 hmm I could have sworn that there was a part for OCI repos in the docs but it seems like there isn't 🤔

There is something in the CLI docs, but that's not too helpful...

Anyways using the example in the OCI docs, if there is a need to have credentials for it, a repository credential of type *oci needs to be created.

  # Add a private HTTPS OCI repository named 'stable'
  argocd repo add oci://registry-1.docker.io/bitnamicharts/nginx --type oci --name stable --username test --password test 

This is a bit confusing, since in the case of Helm repositories there is another (incompatible) way to use OCI credentials with Helm (which is the one you documented)

  # Add a private HTTPS OCI Helm repository named 'stable'
  argocd repo add registry-1.docker.io/bitnamicharts/nginx --type helm --name stable --username test --password test --enable-oci

The confusing part here is that helm credentials are not compatible with oci credentials and vice versa, and the only way those repo types are distinguished are via their repoURL prefixes; if a repoURL is prefixed with oci:// the repo-server will lookup (only) OCI repository credentials and if it's not prefixed with a protocol it the repo-server will (only) lookup Helm OCI credentials.

IMO I think the Helm OCI credential type should be deprecated and removed in the next major release, but that's a topic for another day.

[ppapapetrou76]

thanks @blakepettersson
I updated the docs according to my understanding 😄
Let me know if I need to add / remove / change anything that doesn't make sense

Fixed

[blakepettersson]

Generally LGTM, just a minor comment