Skip to content

feat(terminateCircularRelationships): Add 'immediate' as a value for the terminateCircularRelationships option #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,13 @@ Adds `__typename` property to mock data

Changes enums to TypeScript string union types

### terminateCircularRelationships (`boolean`, defaultValue: `false`)
### terminateCircularRelationships (`boolean | 'immediate'`, defaultValue: `false`)

When enabled, prevents circular relationships from triggering infinite recursion. After the first resolution of a
specific type in a particular call stack, subsequent resolutions will return an empty object cast to the correct type.

When enabled with `immediate`, it will only resolve the relationship once, independently of the call stack. Use this option if you're experiencing `out of memory` errors while generating mocks.

### prefix (`string`, defaultValue: `a` for consonants & `an` for vowels)

The prefix to add to the mock function name. Cannot be empty since it will clash with the associated
Expand Down
23 changes: 14 additions & 9 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type Options<T = TypeNode> = {
types: TypeItem[];
typeNamesConvention: NamingConvention;
enumValuesConvention: NamingConvention;
terminateCircularRelationships: boolean;
terminateCircularRelationships: boolean | 'immediate';
prefix: string | undefined;
typesPrefix: string;
enumsPrefix: string;
Expand All @@ -40,6 +40,9 @@ type Options<T = TypeNode> = {
nonNull: boolean;
};

const getTerminateCircularRelationshipsConfig = ({ terminateCircularRelationships }: TypescriptMocksPluginConfig) =>
terminateCircularRelationships ? terminateCircularRelationships : false;

const convertName = (value: string, fn: (v: string) => string, transformUnderscore: boolean): string => {
if (transformUnderscore) {
return fn(value);
Expand Down Expand Up @@ -430,7 +433,7 @@ const getMockString = (
typeName: string,
fields: string,
typeNamesConvention: NamingConvention,
terminateCircularRelationships: boolean,
terminateCircularRelationships: boolean | 'immediate',
addTypename = false,
prefix,
typesPrefix = '',
Expand All @@ -443,13 +446,15 @@ const getMockString = (
const typenameReturnType = addTypename ? `{ __typename: '${typeName}' } & ` : '';

if (terminateCircularRelationships) {
const relationshipsToOmitInit =
terminateCircularRelationships === 'immediate' ? '_relationshipsToOmit' : 'new Set(_relationshipsToOmit)';
return `
export const ${toMockName(
typeName,
casedName,
prefix,
)} = (overrides?: Partial<${casedNameWithPrefix}>, _relationshipsToOmit: Set<string> = new Set()): ${typenameReturnType}${casedNameWithPrefix} => {
const relationshipsToOmit: Set<string> = new Set(_relationshipsToOmit);
const relationshipsToOmit: Set<string> = ${relationshipsToOmitInit};
relationshipsToOmit.add('${casedName}');
return {${typename}
${fields}
Expand Down Expand Up @@ -541,7 +546,7 @@ export interface TypescriptMocksPluginConfig {
addTypename?: boolean;
prefix?: string;
scalars?: ScalarMap;
terminateCircularRelationships?: boolean;
terminateCircularRelationships?: boolean | 'immediate';
typesPrefix?: string;
enumsPrefix?: string;
transformUnderscore?: boolean;
Expand Down Expand Up @@ -669,7 +674,7 @@ export const plugin: PluginFunction<TypescriptMocksPluginConfig> = (schema, docu
types,
typeNamesConvention,
enumValuesConvention,
terminateCircularRelationships: !!config.terminateCircularRelationships,
terminateCircularRelationships: getTerminateCircularRelationshipsConfig(config),
prefix: config.prefix,
typesPrefix: config.typesPrefix,
enumsPrefix: config.enumsPrefix,
Expand Down Expand Up @@ -706,7 +711,7 @@ export const plugin: PluginFunction<TypescriptMocksPluginConfig> = (schema, docu
types,
typeNamesConvention,
enumValuesConvention,
terminateCircularRelationships: !!config.terminateCircularRelationships,
terminateCircularRelationships: getTerminateCircularRelationshipsConfig(config),
prefix: config.prefix,
typesPrefix: config.typesPrefix,
enumsPrefix: config.enumsPrefix,
Expand All @@ -733,7 +738,7 @@ export const plugin: PluginFunction<TypescriptMocksPluginConfig> = (schema, docu
fieldName,
mockFields,
typeNamesConvention,
!!config.terminateCircularRelationships,
getTerminateCircularRelationshipsConfig(config),
false,
config.prefix,
config.typesPrefix,
Expand All @@ -756,7 +761,7 @@ export const plugin: PluginFunction<TypescriptMocksPluginConfig> = (schema, docu
typeName,
mockFields,
typeNamesConvention,
!!config.terminateCircularRelationships,
getTerminateCircularRelationshipsConfig(config),
!!config.addTypename,
config.prefix,
config.typesPrefix,
Expand All @@ -777,7 +782,7 @@ export const plugin: PluginFunction<TypescriptMocksPluginConfig> = (schema, docu
typeName,
mockFields,
typeNamesConvention,
!!config.terminateCircularRelationships,
getTerminateCircularRelationshipsConfig(config),
!!config.addTypename,
config.prefix,
config.typesPrefix,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`should support setting terminateCircularRelationships as imediate and not create a new set of relationships 1`] = `
"
export const anA = (overrides?: Partial<A>, _relationshipsToOmit: Set<string> = new Set()): A => {
const relationshipsToOmit: Set<string> = _relationshipsToOmit;
relationshipsToOmit.add('A');
return {
B: overrides && overrides.hasOwnProperty('B') ? overrides.B! : relationshipsToOmit.has('B') ? {} as B : aB({}, relationshipsToOmit),
C: overrides && overrides.hasOwnProperty('C') ? overrides.C! : relationshipsToOmit.has('C') ? {} as C : aC({}, relationshipsToOmit),
};
};

export const aB = (overrides?: Partial<B>, _relationshipsToOmit: Set<string> = new Set()): B => {
const relationshipsToOmit: Set<string> = _relationshipsToOmit;
relationshipsToOmit.add('B');
return {
A: overrides && overrides.hasOwnProperty('A') ? overrides.A! : relationshipsToOmit.has('A') ? {} as A : anA({}, relationshipsToOmit),
};
};

export const aC = (overrides?: Partial<C>, _relationshipsToOmit: Set<string> = new Set()): C => {
const relationshipsToOmit: Set<string> = _relationshipsToOmit;
relationshipsToOmit.add('C');
return {
aCollection: overrides && overrides.hasOwnProperty('aCollection') ? overrides.aCollection! : [relationshipsToOmit.has('A') ? {} as A : anA({}, relationshipsToOmit)],
};
};

export const aD = (overrides?: Partial<D>, _relationshipsToOmit: Set<string> = new Set()): D => {
const relationshipsToOmit: Set<string> = _relationshipsToOmit;
relationshipsToOmit.add('D');
return {
A: overrides && overrides.hasOwnProperty('A') ? overrides.A! : relationshipsToOmit.has('A') ? {} as A : anA({}, relationshipsToOmit),
B: overrides && overrides.hasOwnProperty('B') ? overrides.B! : relationshipsToOmit.has('B') ? {} as B : aB({}, relationshipsToOmit),
};
};
"
`;
18 changes: 18 additions & 0 deletions tests/terminateCircularRelationshipsImmediately/schema.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { buildSchema } from 'graphql';

export default buildSchema(/* GraphQL */ `
type A {
B: B!
C: C!
}
type B {
A: A!
}
type C {
aCollection: [A!]!
}
type D {
A: A!
B: B!
}
`);
12 changes: 12 additions & 0 deletions tests/terminateCircularRelationshipsImmediately/spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { plugin } from '../../src';
import testSchema from './schema';

it('should support setting terminateCircularRelationships as imediate and not create a new set of relationships', async () => {
const result = await plugin(testSchema, [], {
terminateCircularRelationships: 'immediate',
});

expect(result).toBeDefined();
expect(result).not.toContain('new Set(_relationshipsToOmit)');
expect(result).toMatchSnapshot();
});
17 changes: 17 additions & 0 deletions tests/terminateCircularRelationshipsImmediately/types.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
export type A = {
B: B;
C: C;
};

export type B = {
A: A;
};

export type C = {
aCollection: A[];
};

export type D = {
A: A;
B: B;
};