Skip to content

feat(terminateCircularRelationships): Add 'immediate' as a value for the terminateCircularRelationships option #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2024

Conversation

rpereira-anchor
Copy link
Contributor

This value will make the mock not create a new Set of relationships to ignore and create a global Set. This will circumvent possible OOM due to large graphs.

fixes #126

@rpereira-anchor rpereira-anchor marked this pull request as ready for review May 14, 2024 16:07
@rpereira-anchor
Copy link
Contributor Author

@ardeois I'm not sure what's happening with the approving workflows. It has been in waiting for some days now.

Copy link
Owner

@ardeois ardeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !
Sorry for the delay, the workflow will run only if the PR has been reviewed

README.md Outdated

When enabled, prevents circular relationships from triggering infinite recursion. After the first resolution of a
specific type in a particular call stack, subsequent resolutions will return an empty object cast to the correct type.

When enabled with `immediate`, it will only resolve the relationship once, ndependently of the call stack. Use this option if you're experiencing `out of memory` errors while generating mocks.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo on ndependently

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@ardeois ardeois added the minor Increment the minor version when merged label May 16, 2024
@ardeois ardeois self-assigned this May 16, 2024
@ardeois
Copy link
Owner

ardeois commented May 16, 2024

@rpereira-anchor Thanks for your contribution, please fix the typo and I'll merge the PR

terminateCircularRelationships option.

This value will make the mock not create a new Set of relationships to
ignore and create a global Set. This will circumvent possible OOM due to
large graphs.
@rpereira-anchor
Copy link
Contributor Author

@rpereira-anchor Thanks for your contribution, please fix the typo and I'll merge the PR

@ardeois typo fixed

@ardeois ardeois enabled auto-merge (squash) May 17, 2024 13:21
@ardeois ardeois merged commit 0717b7d into ardeois:main May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests stuck in infinite loop with nested relationships, despite setting terminateCircularRelationships to true
2 participants