Skip to content

chore(e2e): skip the worst offender of flaky tests. #23772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rusackas merged 1 commit into from
Apr 21, 2023
Merged

chore(e2e): skip the worst offender of flaky tests. #23772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion superset-frontend/cypress-base/cypress/integration/dashboard/editmode.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,8 @@ describe('Dashboard edit', () => {
cy.getBySel('dashboard-charts-filter-search-input').clear();
});

it('should disable the Save button when undoing', () => {
// TODO fix this test! This was the #1 flaky test as of 4/21/23 according to cypress dashboard.
xit('should disable the Save button when undoing', () => {
Comment on lines -737 to +738
Copy link
Copy Markdown
Member

@villebro villebro Apr 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about worst offender; This test was restarted 11 times before I finally caved in and xited it in #23751 😆
image

cy.get('[role="checkbox"]').click();
dragComponent('Unicode Cloud', 'card-title', false);
cy.getBySel('header-save-button').should('be.enabled');
Expand Down