chore(e2e): skip the worst offender of flaky tests.#23772
Merged
Conversation
rusackas
requested review from
betodealmeida,
eschutho,
geido and
jinghua-qa
as code owners
michael-s-molina
approved these changes
Apr 21, 2023
Member
michael-s-molina
left a comment
michael-s-molina
left a comment
There was a problem hiding this comment.
THANK YOU!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Codecov Report
@@ Coverage Diff @@
## master #23772 +/- ##
=======================================
Coverage 67.87% 67.87%
=======================================
Files 1924 1924
Lines 74381 74381
Branches 8106 8106
=======================================
Hits 50486 50486
Misses 21818 21818
Partials 2077 2077
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
villebro
reviewed
Apr 21, 2023
Comment on lines
-737
to
+738
| it('should disable the Save button when undoing', () => { | ||
| // TODO fix this test! This was the #1 flaky test as of 4/21/23 according to cypress dashboard. | ||
| xit('should disable the Save button when undoing', () => { |
Member
There was a problem hiding this comment.
not sure about worst offender; This test was restarted 11 times before I finally caved in and xited it in #23751 😆
eschutho
approved these changes
Apr 21, 2023
sebastianliebscher
pushed a commit
to sebastianliebscher/superset
that referenced
this pull request
Apr 28, 2023
9 tasks
mistercrunch
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Kills this 👆
Adds a TODO for some generous soul who comes along to clean house one fateful day.
https://cloud.cypress.io/projects/ukwxzo/analytics/flaky-tests
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Run E2E
ADDITIONAL INFORMATION