Skip to content

[SPARK-5733] Error Link in Pagination of HistroyPage when showing Incomplete Applications #4523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

marsishandsome
Copy link

The links in pagination of HistroyPage is wrong when showing Incomplete Applications.

If "2" is click on the following page "http://history-server:18080/?page=1&showIncomplete=true", it will go to "http://history-server:18080/?page=2" instead of "http://history-server:18080/?page=2&showIncomplete=true".

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Feb 11, 2015

ok to test

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27281 has started for PR 4523 at commit 9d7b593.

  • This patch merges cleanly.

@srowen
Copy link
Member

srowen commented Feb 11, 2015

Just from reading this page, LGTM. Seems clear that the utility function should be used everywhere to make the page link. Ideally @sarutak can confirm (see #3194)

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27281 has finished for PR 4523 at commit 9d7b593.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class TaskCommitDenied(
    • class CommitDeniedException(
    • class OutputCommitCoordinatorActor(outputCommitCoordinator: OutputCommitCoordinator)

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27281/
Test PASSed.

@sarutak
Copy link
Member

sarutak commented Feb 11, 2015

I applied this changes and confirmed. It's LGTM, thanks @marsishandsome !

asfgit pushed a commit that referenced this pull request Feb 11, 2015
…omplete Applications

The links in pagination of HistroyPage is wrong when showing Incomplete Applications.

If "2" is click on the following page "http://history-server:18080/?page=1&showIncomplete=true", it will go to "http://history-server:18080/?page=2" instead of "http://history-server:18080/?page=2&showIncomplete=true".

Author: guliangliang <[email protected]>

Closes #4523 from marsishandsome/Spark5733 and squashes the following commits:

9d7b593 [guliangliang] [SPARK-5733] Error Link in Pagination of HistroyPage when showing Incomplete Applications

(cherry picked from commit 1ac099e)
Signed-off-by: Sean Owen <[email protected]>
@asfgit asfgit closed this in 1ac099e Feb 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants