[SPARK-4329][WebUI] HistoryPage pagenation #3194

sarutak · 2014-11-11T00:11:50Z

Current HistoryPage have links only to previous page or next page.
I suggest to add index to access history pages easily.

I implemented like following pics.

If there are many pages, current page +/- N pages, head page and last page are indexed.

SparkQA · 2014-11-11T00:15:14Z

Test build #23174 has started for PR 3194 at commit cfa242b.

This patch merges cleanly.

SparkQA · 2014-11-11T01:20:38Z

Test build #23174 has finished for PR 3194 at commit cfa242b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-11-11T01:20:41Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23174/
Test FAILed.

sarutak · 2014-11-11T01:22:35Z

I think the failure above is not related my changes.

Jenkins, retest this please.

sarutak · 2014-11-11T02:10:05Z

retest this please.

SparkQA · 2014-11-11T02:12:39Z

Test build #23187 has started for PR 3194 at commit cfa242b.

This patch merges cleanly.

SparkQA · 2014-11-11T03:36:51Z

Test build #23187 has finished for PR 3194 at commit cfa242b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-11-11T03:36:54Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23187/
Test PASSed.

andrewor14 · 2014-11-11T19:22:19Z

Yes!! I've been wanting to add this ever since 1.0. I'll take a look at this after the release. Also, I think +/- 2 pages is enough. Right now it looks a little cluttered.

…-indexing

sarutak · 2014-11-12T00:05:15Z

@andrewor14 Thanks for taking a look at this PR!
I'll modify codes to be simpler.

SparkQA · 2014-11-12T00:24:45Z

Test build #23229 has started for PR 3194 at commit ec7922e.

This patch merges cleanly.

SparkQA · 2014-11-12T00:25:55Z

Test build #23229 has finished for PR 3194 at commit ec7922e.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- trait LeaderElectionAgent
- trait LeaderElectable
- trait PersistenceEngine
- abstract class StandaloneRecoveryModeFactory(conf: SparkConf)
- class IndexShuffleBlockManager(conf: SparkConf) extends ShuffleBlockManager
- public final class LazyFileRegion extends AbstractReferenceCounted implements FileRegion

AmplabJenkins · 2014-11-12T00:25:56Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23229/
Test FAILed.

SparkQA · 2014-11-12T00:34:55Z

Test build #23230 has started for PR 3194 at commit b2240f8.

This patch merges cleanly.

SparkQA · 2014-11-12T02:01:31Z

Test build #23230 has finished for PR 3194 at commit b2240f8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-11-12T02:01:34Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23230/
Test PASSed.

…-indexing

SparkQA · 2014-11-18T08:00:00Z

Test build #23543 has started for PR 3194 at commit 76b05e3.

This patch merges cleanly.

SparkQA · 2014-11-18T09:25:38Z

Test build #23543 has finished for PR 3194 at commit 76b05e3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-11-18T09:25:42Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23543/
Test PASSed.

…-indexing

SparkQA · 2014-12-01T01:17:37Z

Test build #23963 has started for PR 3194 at commit 1c2f605.

This patch merges cleanly.

SparkQA · 2014-12-01T02:38:52Z

Test build #23963 has finished for PR 3194 at commit 1c2f605.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-12-01T02:38:55Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23963/
Test PASSed.

…-indexing

SparkQA · 2014-12-10T01:15:30Z

Test build #24279 has started for PR 3194 at commit c93932e.

This patch merges cleanly.

andrewor14 · 2014-12-10T01:40:41Z

core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala

+    val littlerSideIndices =
+      rangeIndices(actualPage - maxNumIndices until actualPage, 1 < _)
+    val greaterSideIndices =
+      rangeIndices(actualPage + 1 to actualPage + maxNumIndices, _ < pageCount)


These could just be leftSideIndices and rightSideIndices

andrewor14 · 2014-12-10T01:53:13Z

Hey just a few minor comments but the approach looks good. Thanks for working on this.

sarutak · 2014-12-10T01:55:40Z

@andrewor14 Thanks for all of your comments! I'll fix soon.

SparkQA · 2014-12-10T02:30:27Z

Test build #24290 has started for PR 3194 at commit 15d3d2d.

This patch merges cleanly.

SparkQA · 2014-12-10T02:32:59Z

Test build #24279 has finished for PR 3194 at commit c93932e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-12-10T02:33:02Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24279/
Test PASSed.

andrewor14 · 2014-12-10T02:54:17Z

core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala

+            // `plusOrMinus` pages of the current page.
+            // Regardless of where the current page is,
+            // this also links to the first and last page.
+            // If the current page +/- `plusOrMinux` is greater than the 2nd page


plusOrMinux, I'll fix this when I merge don't worry

andrewor14 · 2014-12-10T02:54:37Z

LGTM

SparkQA · 2014-12-10T03:47:45Z

Test build #24290 has finished for PR 3194 at commit 15d3d2d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2014-12-10T03:47:49Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24290/
Test PASSed.

andrewor14 · 2014-12-10T20:28:46Z

I'm merging this into master thanks.

Added index to HistoryPage

cfa242b

sarutak changed the title ~~[SPARK-4329] Add indexing feature for HistoryPage~~ [SPARK-4329][WebUI] Add indexing feature for HistoryPage Nov 11, 2014

sarutak changed the title ~~[SPARK-4329][WebUI] Add indexing feature for HistoryPage~~ [SPARK-4329][WebUI] HistoryPage pagenation Nov 11, 2014

Merge branch 'master' of git://git.apache.org/spark into history-page…

755a004

…-indexing

Simplified code

ec7922e

Fixed style

b2240f8

Merge branch 'master' of git://git.apache.org/spark into history-page…

76b05e3

…-indexing

Merge branch 'master' of git://git.apache.org/spark into history-page…

1c2f605

…-indexing

Merge branch 'master' of git://git.apache.org/spark into history-page…

c93932e

…-indexing

andrewor14 reviewed Dec 10, 2014
View reviewed changes

Simplified code

15d3d2d

andrewor14 reviewed Dec 10, 2014
View reviewed changes

asfgit closed this in 0fc637b Dec 10, 2014

srowen mentioned this pull request Feb 11, 2015

[SPARK-5733] Error Link in Pagination of HistroyPage when showing Incomplete Applications #4523

Closed

sarutak deleted the history-page-indexing branch April 11, 2015 05:20

[SPARK-4329][WebUI] HistoryPage pagenation #3194

[SPARK-4329][WebUI] HistoryPage pagenation #3194

Uh oh!

Conversation

sarutak commented Nov 11, 2014

Uh oh!

SparkQA commented Nov 11, 2014

Uh oh!

SparkQA commented Nov 11, 2014

Uh oh!

AmplabJenkins commented Nov 11, 2014

Uh oh!

sarutak commented Nov 11, 2014

Uh oh!

sarutak commented Nov 11, 2014

Uh oh!

SparkQA commented Nov 11, 2014

Uh oh!

SparkQA commented Nov 11, 2014

Uh oh!

AmplabJenkins commented Nov 11, 2014

Uh oh!

andrewor14 commented Nov 11, 2014

Uh oh!

sarutak commented Nov 12, 2014

Uh oh!

SparkQA commented Nov 12, 2014

Uh oh!

SparkQA commented Nov 12, 2014

Uh oh!

AmplabJenkins commented Nov 12, 2014

Uh oh!

SparkQA commented Nov 12, 2014

Uh oh!

SparkQA commented Nov 12, 2014

Uh oh!

AmplabJenkins commented Nov 12, 2014

Uh oh!

SparkQA commented Nov 18, 2014

Uh oh!

SparkQA commented Nov 18, 2014

Uh oh!

AmplabJenkins commented Nov 18, 2014

Uh oh!

SparkQA commented Dec 1, 2014

Uh oh!

SparkQA commented Dec 1, 2014

Uh oh!

AmplabJenkins commented Dec 1, 2014

Uh oh!

SparkQA commented Dec 10, 2014

Uh oh!

andrewor14 Dec 10, 2014

Choose a reason for hiding this comment

Uh oh!

andrewor14 commented Dec 10, 2014

Uh oh!

sarutak commented Dec 10, 2014

Uh oh!

SparkQA commented Dec 10, 2014

Uh oh!

SparkQA commented Dec 10, 2014

Uh oh!

AmplabJenkins commented Dec 10, 2014

Uh oh!

andrewor14 Dec 10, 2014

Choose a reason for hiding this comment

Uh oh!

andrewor14 commented Dec 10, 2014

Uh oh!

SparkQA commented Dec 10, 2014

Uh oh!

AmplabJenkins commented Dec 10, 2014

Uh oh!

andrewor14 commented Dec 10, 2014

Uh oh!

Uh oh!