[SPARK-33422][DOC] Fix the correct display of left menu item #30335
Conversation
|
ok to test |
maropu
changed the title
|
I've checked it manually and the change seems fine. cc: @HyukjinKwon @gatorsmile @huaxingao |
|
Test build #130935 has finished for PR 30335 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #130953 has finished for PR 30335 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
| @@ -325,6 +325,7 @@ a.anchorjs-link:hover { text-decoration: none; } | |||
| border-bottom-width: 0px; | |||
| margin-top: 0px; | |||
| width: 210px; | |||
| height: 80%; | |||
There was a problem hiding this comment.
Looks like it wouldn't work properly when the side bar is folded:
Before:
After:
There was a problem hiding this comment.
also the end of bat does not seem matching:
| @@ -325,6 +325,7 @@ a.anchorjs-link:hover { text-decoration: none; } | |||
| border-bottom-width: 0px; | |||
| margin-top: 0px; | |||
| width: 210px; | |||
There was a problem hiding this comment.
Since we're here, shall we batch left-menu.width to 210 px too? That makes the subtitles look truncated. I don't know why we made that longer specifically (https://github.com/apache/spark/pull/25459/files#r521829348).
And, actually we should make the width itself more wider. I would suggest to make it 280px. cc @gatorsmile and @dilipbiswal
There was a problem hiding this comment.
Hi @HyukjinKwon As I modified, the horizontal scrollbar can be displayed and used after setting the height to 80%
after:
There was a problem hiding this comment.
How does that sound @HyukjinKwon
There was a problem hiding this comment.
That's fine. Can be separately done. but I think we should still fix #30335 (comment).
There was a problem hiding this comment.
Ok，Thanks @HyukjinKwon and @srowen , I will submit the code separately as a fix for the next issues.
dongjoon-hyun
changed the title
|
@liucht-inspur, can you try what I mentioned in #30335 (comment)? After this change, it looks a bit odds when it's folded. |
|
Hi @HyukjinKwon I have finished the repair, please help to review,thanks! |
|
Test build #131275 has finished for PR 30335 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Okay, at least it looks better. Merged to master and branch-3.0. |
|
Thanks for your contribution @liucht-inspur. |
### What changes were proposed in this pull request? Limit the height of the menu area on the left to display vertical scroll bar ### Why are the changes needed? The bottom menu item cannot be displayed when the left menu tree is long ### Does this PR introduce any user-facing change? Yes, if the menu item shows more, you'll see it by pulling down the vertical scroll bar before:  after:  ### How was this patch tested? NA Closes #30335 from liucht-inspur/master. Authored-by: liucht <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit cbc8be2) Signed-off-by: HyukjinKwon <[email protected]>
What changes were proposed in this pull request?
Limit the height of the menu area on the left to display vertical scroll bar
Why are the changes needed?
The bottom menu item cannot be displayed when the left menu tree is long
Does this PR introduce any user-facing change?
Yes, if the menu item shows more, you'll see it by pulling down the vertical scroll bar
before:
after:
How was this patch tested?
NA